diff options
| author | Daniel P. Berrange <berrange@redhat.com> | 2017-11-21 14:25:38 +0000 |
|---|---|---|
| committer | Peter Maydell <peter.maydell@linaro.org> | 2017-11-21 15:42:47 +0000 |
| commit | 7c3d1917fd7a3de906170fa3d6d3d4c5918b1e49 (patch) | |
| tree | fab0f893846bee424fd93d6111592e785e21b255 | |
| parent | 70b7fba9871fb282b4806a2445a1e82a7a51da10 (diff) | |
build: disarm the TCG unit test trap
Developers sometimes mistakenly run 'make test' instead of 'make check'.
'make test' triggers the ancient, unmaintained tcg unit tests in
tests/tcg/Makefile which have long since ceased compiling.
Even if someone fixes the TCG tests, it makes little sense to put
them in a 'make test' target, rather they should be 'make check-tcg',
possibly wired up as a dependency of 'make check'.
In the meantime, this patch disarms the 'make test' trap by simply
deleting it so users get an immediate error. This should be enough
for them to remember to type 'make check' instead (or 'make help'
to learn). It also deletes 'make speed' which is another route
into the tcg tests.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Kashyap Chamarthy <kchamart@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb@linux.vnet.ibm.com>
Message-id: 20171121142538.22072-1-berrange@redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| -rw-r--r-- | Makefile | 6 |
1 files changed, 1 insertions, 5 deletions
@@ -253,7 +253,7 @@ Makefile: ; configure: ; .PHONY: all clean cscope distclean html info install install-doc \ - pdf txt recurse-all speed test dist msi FORCE + pdf txt recurse-all dist msi FORCE $(call set-vpath, $(SRC_PATH)) @@ -716,10 +716,6 @@ endif $(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \ done -# various test targets -test speed: all - $(MAKE) -C tests/tcg $@ - .PHONY: ctags ctags: rm -f tags |