diff options
| author | Philippe Mathieu-Daudé <philmd@linaro.org> | 2024-04-08 11:41:59 +0200 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2024-04-10 19:38:01 +0300 |
| commit | 9b7bc39890b6bea852db9e1427648e28f61e751b (patch) | |
| tree | b002b9de3e8fad9e5ecb10e86517f4a729be42d9 | |
| parent | 8394be7faa2d200046a902bdec9cdb1d6fdb3ae0 (diff) | |
hw/misc/applesmc: Fix memory leak in reset() handler
AppleSMCData is allocated with g_new0() in applesmc_add_key():
release it with g_free().
Leaked since commit 1ddda5cd36 ("AppleSMC device emulation").
Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240408095217.57239-3-philmd@linaro.org>
(cherry picked from commit fc09ff2979defdcf8d00c2db94022d5d610e36ba)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
| -rw-r--r-- | hw/misc/applesmc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c index 5f9c742e50..80642efc57 100644 --- a/hw/misc/applesmc.c +++ b/hw/misc/applesmc.c @@ -273,6 +273,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev) /* Remove existing entries */ QLIST_FOREACH_SAFE(d, &s->data_def, node, next) { QLIST_REMOVE(d, node); + g_free(d); } s->status = 0x00; s->status_1e = 0x00; |