diff options
| author | Eduardo Habkost <ehabkost@redhat.com> | 2015-09-29 17:34:23 -0300 |
|---|---|---|
| committer | Eduardo Habkost <ehabkost@redhat.com> | 2015-10-27 15:52:11 -0200 |
| commit | 712b4243c761cb6ab6a4367a160fd2a42e2d4b76 (patch) | |
| tree | 2ac1a7b6ebaeb5c6124e46ba06ea13cdc9a95749 | |
| parent | 7e038b94e74e1c2d1b3598e2e4b0b5c8b79a7278 (diff) | |
target-i386: Don't left shift negative constant
Left shift of negative values is undefined behavior. Detected by clang:
qemu/target-i386/translate.c:2423:26: runtime error:
left shift of negative value -8
This changes the code to reverse the sign after the left shift.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
| -rw-r--r-- | target-i386/translate.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/target-i386/translate.c b/target-i386/translate.c index 764b1e44b7..862f8e09fb 100644 --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -2432,7 +2432,7 @@ static void gen_pusha(DisasContext *s) { int i; gen_op_movl_A0_reg(R_ESP); - gen_op_addl_A0_im(-8 << s->dflag); + gen_op_addl_A0_im(-(8 << s->dflag)); if (!s->ss32) tcg_gen_ext16u_tl(cpu_A0, cpu_A0); tcg_gen_mov_tl(cpu_T[1], cpu_A0); |