diff options
| author | Akihiko Odaki <akihiko.odaki@daynix.com> | 2024-01-29 17:03:08 +0900 |
|---|---|---|
| committer | Michael Tokarev <mjt@tls.msk.ru> | 2024-02-13 21:06:28 +0300 |
| commit | 0fd604b02ab880f3c8416d8f9e74eaa55f43cb56 (patch) | |
| tree | eb0270dae66e13f82f8c41f872bfa65923332041 | |
| parent | 258293b564d00d8c34419442da3fd7b8108eaee4 (diff) | |
hw/smbios: Fix port connector option validation
qemu_smbios_type8_opts did not have the list terminator and that
resulted in out-of-bound memory access. It also needs to have an element
for the type option.
Cc: qemu-stable@nongnu.org
Fixes: fd8caa253c56 ("hw/smbios: support for type 8 (port connector)")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
(cherry picked from commit 196578c9d051d19c23e6c13e97b791a41b318315)
| -rw-r--r-- | hw/smbios/smbios.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 7a58d50d80..9f4d007d96 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -346,6 +346,11 @@ static const QemuOptDesc qemu_smbios_type4_opts[] = { static const QemuOptDesc qemu_smbios_type8_opts[] = { { + .name = "type", + .type = QEMU_OPT_NUMBER, + .help = "SMBIOS element type", + }, + { .name = "internal_reference", .type = QEMU_OPT_STRING, .help = "internal reference designator", @@ -365,6 +370,7 @@ static const QemuOptDesc qemu_smbios_type8_opts[] = { .type = QEMU_OPT_NUMBER, .help = "port type", }, + { /* end of list */ } }; static const QemuOptDesc qemu_smbios_type11_opts[] = { |