diff options
author | Luiz Capitulino <lcapitulino@redhat.com> | 2013-01-08 19:26:25 -0200 |
---|---|---|
committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2013-01-14 12:00:20 -0600 |
commit | 6ffacc5d3ddf2e3227aae2a8cc5c15627265f727 (patch) | |
tree | be9ce2b84974ea9dc8aa3d38b78fd0ae5d506b33 | |
parent | a507db9599599ce33007b524276a6ea88e521662 (diff) |
qemu-ga: ga_open_pidfile(): use qemu_open()
This ensures that O_CLOEXEC is passed to open(), this way the
pid file fd is not leaked to executed processes.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Acked-by: Amos Kong <akong@redhat.com>
Tested-by: Amos Kong <akong@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
-rw-r--r-- | qga/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/qga/main.c b/qga/main.c index a9b968c507..4239150d4e 100644 --- a/qga/main.c +++ b/qga/main.c @@ -267,7 +267,7 @@ static bool ga_open_pidfile(const char *pidfile) int pidfd; char pidstr[32]; - pidfd = open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); + pidfd = qemu_open(pidfile, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); if (pidfd == -1 || lockf(pidfd, F_TLOCK, 0)) { g_critical("Cannot lock pid file, %s", strerror(errno)); if (pidfd != -1) { |