aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFam Zheng <famz@redhat.com>2018-03-15 11:51:57 +0800
committerKevin Wolf <kwolf@redhat.com>2018-03-19 12:01:39 +0100
commit2c860e797ab2af7393c767cdd9e27aa1eecfc812 (patch)
treeee189c1670addceb27f0b8a092966683b1359761
parent4f8e3a1f225ea51707e2eec0aef5e8758b4d7e40 (diff)
block: Fix leak of ignore_children in error path
Reported-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Fam Zheng <famz@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Alberto Garcia <berto@igalia.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r--block.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block.c b/block.c
index e02d83b027..f7f9d8eca7 100644
--- a/block.c
+++ b/block.c
@@ -3679,12 +3679,12 @@ int bdrv_drop_intermediate(BlockDriverState *top, BlockDriverState *base,
GSList *ignore_children = g_slist_prepend(NULL, c);
bdrv_check_update_perm(base, NULL, c->perm, c->shared_perm,
ignore_children, &local_err);
+ g_slist_free(ignore_children);
if (local_err) {
ret = -EPERM;
error_report_err(local_err);
goto exit;
}
- g_slist_free(ignore_children);
/* If so, update the backing file path in the image file */
if (c->role->update_filename) {