aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2016-07-11 14:10:09 +0100
committerPeter Maydell <peter.maydell@linaro.org>2016-07-11 14:10:09 +0100
commitb3b22db69fdefbde00a4499453b76c6b57464711 (patch)
tree9373a354917828ced43dbd0a0e2ccaa528f11dd3
parentf7d3f8c0c0737b3b99a45b46ea23f4ab15cdb135 (diff)
parentcdbd727c20ad7aac7797dc8c95e485e1a4c6901b (diff)
Merge remote-tracking branch 'remotes/rth/tags/pull-rth-20160710' into staging
build fix for travis # gpg: Signature made Sun 10 Jul 2016 18:07:02 BST # gpg: using RSA key 0xAD1270CC4DD0279B # gpg: Good signature from "Richard Henderson <rth7680@gmail.com>" # gpg: aka "Richard Henderson <rth@redhat.com>" # gpg: aka "Richard Henderson <rth@twiddle.net>" # Primary key fingerprint: 9CB1 8DDA F8E8 49AD 2AFC 16A4 AD12 70CC 4DD0 279B * remotes/rth/tags/pull-rth-20160710: build: Use $(AS) for optionrom explicitly linux-user: Fix i386 safe-syscall.S Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-rwxr-xr-xconfigure10
-rw-r--r--linux-user/host/i386/safe-syscall.inc.S24
-rw-r--r--pc-bios/optionrom/Makefile3
-rw-r--r--rules.mak2
4 files changed, 13 insertions, 26 deletions
diff --git a/configure b/configure
index e9090a0d29..5ada56d984 100755
--- a/configure
+++ b/configure
@@ -368,6 +368,7 @@ else
fi
ar="${AR-${cross_prefix}ar}"
+as="${AS-${cross_prefix}as}"
ccas="${CCAS-$cc}"
cpp="${CPP-$cc -E}"
objcopy="${OBJCOPY-${cross_prefix}objcopy}"
@@ -4490,13 +4491,6 @@ if test "$fortify_source" != "no"; then
fi
fi
-#################################################
-# clang does not support the 16-bit assembly for roms
-
-if echo | $ccas -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
- ccas="$ccas -fno-integrated-as"
-fi
-
##########################################
# check if struct fsxattr is available via linux/fs.h
@@ -5515,6 +5509,7 @@ echo "CXX=$cxx" >> $config_host_mak
echo "OBJCC=$objcc" >> $config_host_mak
echo "AR=$ar" >> $config_host_mak
echo "ARFLAGS=$ARFLAGS" >> $config_host_mak
+echo "AS=$as" >> $config_host_mak
echo "CCAS=$ccas" >> $config_host_mak
echo "CPP=$cpp" >> $config_host_mak
echo "OBJCOPY=$objcopy" >> $config_host_mak
@@ -5988,6 +5983,7 @@ for rom in seabios vgabios ; do
config_mak=roms/$rom/config.mak
echo "# Automatically generated by configure - do not modify" > $config_mak
echo "SRC_PATH=$source_path/roms/$rom" >> $config_mak
+ echo "AS=$as" >> $config_mak
echo "CCAS=$ccas" >> $config_mak
echo "CC=$cc" >> $config_mak
echo "BCC=bcc" >> $config_mak
diff --git a/linux-user/host/i386/safe-syscall.inc.S b/linux-user/host/i386/safe-syscall.inc.S
index 766d0ded98..9e58fc6504 100644
--- a/linux-user/host/i386/safe-syscall.inc.S
+++ b/linux-user/host/i386/safe-syscall.inc.S
@@ -69,7 +69,7 @@ safe_syscall_base:
safe_syscall_start:
/* if signal_pending is non-zero, don't do the call */
mov 4+16(%esp), %eax /* signal_pending */
- cmp $0, (%eax)
+ cmpl $0, (%eax)
jnz 1f
mov 8+16(%esp), %eax /* syscall number */
int $0x80
@@ -77,16 +77,16 @@ safe_syscall_end:
/* code path for having successfully executed the syscall */
pop %ebx
.cfi_remember_state
- .cfi_def_cfa_offset -4
+ .cfi_adjust_cfa_offset -4
.cfi_restore ebx
pop %edi
- .cfi_def_cfa_offset -4
+ .cfi_adjust_cfa_offset -4
.cfi_restore edi
pop %esi
- .cfi_def_cfa_offset -4
+ .cfi_adjust_cfa_offset -4
.cfi_restore esi
pop %ebp
- .cfi_def_cfa_offset -4
+ .cfi_adjust_cfa_offset -4
.cfi_restore ebp
ret
@@ -94,19 +94,7 @@ safe_syscall_end:
/* code path when we didn't execute the syscall */
.cfi_restore_state
mov $-TARGET_ERESTARTSYS, %eax
- pop %ebx
- .cfi_def_cfa_offset -4
- .cfi_restore ebx
- pop %edi
- .cfi_def_cfa_offset -4
- .cfi_restore edi
- pop %esi
- .cfi_def_cfa_offset -4
- .cfi_restore esi
- pop %ebp
- .cfi_def_cfa_offset -4
- .cfi_restore ebp
- ret
+ jmp safe_syscall_end
.cfi_endproc
.size safe_syscall_base, .-safe_syscall_base
diff --git a/pc-bios/optionrom/Makefile b/pc-bios/optionrom/Makefile
index ce4852a4d5..2cdda87f0e 100644
--- a/pc-bios/optionrom/Makefile
+++ b/pc-bios/optionrom/Makefile
@@ -20,6 +20,9 @@ build-all: multiboot.bin linuxboot.bin kvmvapic.bin
# suppress auto-removal of intermediate files
.SECONDARY:
+%.o: %.S
+ $(call quiet-command,$(CPP) $(QEMU_INCLUDES) $(QEMU_DGFLAGS) $(CFLAGS) -c -o - $< | $(AS) $(ASFLAGS) -o $@," AS $(TARGET_DIR)$@")
+
%.img: %.o
$(call quiet-command,$(LD) $(LDFLAGS_NOPIE) -Ttext 0 -e _start -s -o $@ $<," Building $(TARGET_DIR)$@")
diff --git a/rules.mak b/rules.mak
index 7d7d83b124..ed8e482780 100644
--- a/rules.mak
+++ b/rules.mak
@@ -69,7 +69,7 @@ LINK = $(call quiet-command, $(LINKPROG) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o
$(version-obj-y) $(call extract-libs,$1) $(LIBS)," LINK $(TARGET_DIR)$@")
%.o: %.S
- $(call quiet-command,$(CCAS) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," AS $(TARGET_DIR)$@")
+ $(call quiet-command,$(CCAS) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," CCAS $(TARGET_DIR)$@")
%.o: %.cc
$(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," CXX $(TARGET_DIR)$@")