aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAmador Pahim <apahim@redhat.com>2017-09-01 13:28:17 +0200
committerEduardo Habkost <ehabkost@redhat.com>2017-09-15 20:12:00 -0300
commitf6cf7f5a227ca0c8cc540d78d4f0f943c51ea8d1 (patch)
tree711e8943d1b4c265644e0e1c404b2afb1146712b
parent4d9342977a2e8b195609d332fcd64a93a48c158b (diff)
qemu.py: fix is_running() return before first launch()
is_running() returns None when called before the first time we call launch(): >>> import qemu >>> vm = qemu.QEMUMachine('qemu-system-x86_64') >>> vm.is_running() >>> It should return False instead. This patch fixes that. For consistence, this patch removes the parenthesis from the second clause as it's not really needed. Signed-off-by: Amador Pahim <apahim@redhat.com> Message-Id: <20170901112829.2571-2-apahim@redhat.com> Reviewed-by: Fam Zheng <famz@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
-rw-r--r--scripts/qemu.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 7c6802609a..f80b008f7f 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -131,7 +131,7 @@ class QEMUMachine(object):
raise
def is_running(self):
- return self._popen and (self._popen.returncode is None)
+ return self._popen is not None and self._popen.returncode is None
def exitcode(self):
if self._popen is None: