aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2016-06-28 00:12:03 +0200
committerMichael S. Tsirkin <mst@redhat.com>2016-09-09 20:58:34 +0300
commita8bba0ada41b228e4dd5113a02f20bbc0f5d6f0a (patch)
treebf109deb32d9ada555a0c75e4d7ae648744274f5
parentc2a57aae9a1c3dd7de77daf5478df10379aeeebf (diff)
virtio: Tell the user what went wrong when event_notifier_init failed
event_notifier_init() can fail in real life, for example when there are not enough open file handles available (EMFILE) when using a lot of devices. So instead of leaving the average user with a cryptic error number only, print out a proper error message with strerror() instead, so that the user has a better way to figure out what is going on and that using "ulimit -n" might help here for example. Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
-rw-r--r--hw/virtio/virtio-bus.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c
index a85b7c8abe..14927935ae 100644
--- a/hw/virtio/virtio-bus.c
+++ b/hw/virtio/virtio-bus.c
@@ -164,7 +164,8 @@ static int set_host_notifier_internal(DeviceState *proxy, VirtioBusState *bus,
if (assign) {
r = event_notifier_init(notifier, 1);
if (r < 0) {
- error_report("%s: unable to init event notifier: %d", __func__, r);
+ error_report("%s: unable to init event notifier: %s (%d)",
+ __func__, strerror(-r), r);
return r;
}
virtio_queue_set_host_notifier_fd_handler(vq, true, set_handler);