aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2016-02-09 11:59:16 +0100
committerGerd Hoffmann <kraxel@redhat.com>2016-02-22 08:38:42 +0100
commit327d83ba717c879f5640b41c15af3ce56a7922eb (patch)
treee6367b30131d642ff48b4ba6a38d1f2cea2bcfbf
parentc3bce9d5f986bc22b0692a8fa9d26ce6d304375c (diff)
gtk: fix uninitialized temporary VirtualConsole
Only the echo field is used in the temporary VirtualConsole, so the damage was limited. But still, if echo was incorrectly set to true, the result would be some puzzling output in VTE monitor and serial consoles. Fixes: fba958c692e47a373d15c1fd3d72b255bf76adbd Cc: Gerd Hoffmann <kraxel@redhat.com> Tested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Message-id: 1455015557-15106-2-git-send-email-pbonzini@redhat.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
-rw-r--r--ui/gtk.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ui/gtk.c b/ui/gtk.c
index 2b46965f80..3773826277 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1613,7 +1613,7 @@ static CharDriverState *gd_vc_handler(ChardevVC *vc, Error **errp)
chr->chr_set_echo = gd_vc_chr_set_echo;
/* Temporary, until gd_vc_vte_init runs. */
- chr->opaque = g_new(VirtualConsole, 1);
+ chr->opaque = g_new0(VirtualConsole, 1);
/* defer OPENED events until our vc is fully initialized */
chr->explicit_be_open = true;