diff options
| author | Richard Henderson <rth@twiddle.net> | 2013-09-14 15:57:22 -0700 |
|---|---|---|
| committer | Richard Henderson <rth@twiddle.net> | 2013-10-10 11:44:25 -0700 |
| commit | 100b5e0170e86661aaf830869be930a1a201ed08 (patch) | |
| tree | a3db370b1d116a4abdecc838da63663151aaf300 | |
| parent | f5daeec412b9624ba902bdba26edff88a1694ea6 (diff) | |
tcg: Put target helper data into an array.
One call inside of a loop to tcg_register_helper instead of hundreds
of sequential calls.
Presumably more icache and branch prediction friendly; resulting binary
size mostly unchanged on x86_64, as we're trading 32-bit rip-relative
references in .text for full 64-bit pointers in .rodata.
Signed-off-by: Richard Henderson <rth@twiddle.net>
| -rw-r--r-- | include/exec/def-helper.h | 3 | ||||
| -rw-r--r-- | tcg/tcg.c | 17 |
2 files changed, 15 insertions, 5 deletions
diff --git a/include/exec/def-helper.h b/include/exec/def-helper.h index 022a9ceb6a..73d51f9cf5 100644 --- a/include/exec/def-helper.h +++ b/include/exec/def-helper.h @@ -240,8 +240,7 @@ static inline void glue(gen_helper_, name)(dh_retvar_decl(ret) \ #elif GEN_HELPER == 2 /* Register helpers. */ -#define DEF_HELPER_FLAGS_0(name, flags, ret) \ -tcg_register_helper(HELPER(name), #name); +#define DEF_HELPER_FLAGS_0(name, flags, ret) { HELPER(name), #name }, #define DEF_HELPER_FLAGS_1(name, flags, ret, t1) \ DEF_HELPER_FLAGS_0(name, flags, ret) @@ -256,9 +256,19 @@ void tcg_pool_reset(TCGContext *s) #include "helper.h" +typedef struct TCGHelperInfo { + void *func; + const char *name; +} TCGHelperInfo; + +static const TCGHelperInfo all_helpers[] = { +#define GEN_HELPER 2 +#include "helper.h" +}; + void tcg_context_init(TCGContext *s) { - int op, total_args, n; + int op, total_args, n, i; TCGOpDef *def; TCGArgConstraint *args_ct; int *sorted_args; @@ -288,8 +298,9 @@ void tcg_context_init(TCGContext *s) } /* Register helpers. */ -#define GEN_HELPER 2 -#include "helper.h" + for (i = 0; i < ARRAY_SIZE(all_helpers); ++i) { + tcg_register_helper(all_helpers[i].func, all_helpers[i].name); + } tcg_target_init(s); } |