diff options
| author | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2020-03-24 18:36:29 +0300 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2020-06-22 12:52:20 -0500 |
| commit | 1c8d9fb334322762fe2feefa3c6d29571ddea513 (patch) | |
| tree | bb3e52b3a9d2b4da50ad18ddfdc1505cd9079a57 | |
| parent | 09397e965739bd7da25bf1739a89fe2f245e8446 (diff) | |
migration/ram: fix use after free of local_err
local_err is used again in migration_bitmap_sync_precopy() after
precopy_notify(), so we must zero it. Otherwise try to set
non-NULL local_err will crash.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200324153630.11882-6-vsementsov@virtuozzo.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
(cherry picked from commit b4a1733c5e6827c72b0dcfa295e07ef7b1ebccff)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
| -rw-r--r-- | migration/ram.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/migration/ram.c b/migration/ram.c index b6de7d1d55..c44542175d 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1906,6 +1906,7 @@ static void migration_bitmap_sync_precopy(RAMState *rs) */ if (precopy_notify(PRECOPY_NOTIFY_BEFORE_BITMAP_SYNC, &local_err)) { error_report_err(local_err); + local_err = NULL; } migration_bitmap_sync(rs); |