diff options
| author | Gerd Hoffmann <kraxel@redhat.com> | 2013-12-11 12:58:41 +0100 |
|---|---|---|
| committer | Gerd Hoffmann <kraxel@redhat.com> | 2014-06-13 12:34:57 +0200 |
| commit | 8bc891279604186562f59a4239e42dcb451c60d3 (patch) | |
| tree | b65636c58164dc93f17b0035e708b367530a1bd9 | |
| parent | 2a2c4830c0068d70443f3dddc4cc668f0c601b5c (diff) | |
inet_listen_opts: add error checking
Don't use atoi() function which doesn't detect errors, switch to
strtol and error out on failures. Also add a range check while
being at it.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
| -rw-r--r-- | util/qemu-sockets.c | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index e3d29eebb8..a4a1e9d300 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -131,8 +131,19 @@ int inet_listen_opts(QemuOpts *opts, int port_offset, Error **errp) ai.ai_family = PF_INET6; /* lookup */ - if (port_offset) - snprintf(port, sizeof(port), "%d", atoi(port) + port_offset); + if (port_offset) { + unsigned long long baseport; + if (parse_uint_full(port, &baseport, 10) < 0) { + error_setg(errp, "can't convert to a number: %s", port); + return -1; + } + if (baseport > 65535 || + baseport + port_offset > 65535) { + error_setg(errp, "port %s out of range", port); + return -1; + } + snprintf(port, sizeof(port), "%d", (int)baseport + port_offset); + } rc = getaddrinfo(strlen(addr) ? addr : NULL, port, &ai, &res); if (rc != 0) { error_setg(errp, "address resolution failed for %s:%s: %s", addr, port, |