diff options
author | Markus Armbruster <armbru@redhat.com> | 2017-02-17 21:15:54 +0100 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2017-03-15 08:52:09 +0100 |
commit | 157db293ebf640d0ad04498ca469dcd3839a4e41 (patch) | |
tree | 1639cf9270f592d0755b6f7a3438d75ab9c7b582 | |
parent | d84f714eafedd8bb9d4aaec8b76417bef8e3535e (diff) |
tests: Use error_free_or_abort() where appropriate
Done with this Coccinelle semantic patch:
@@
expression E;
@@
- g_assert(E);
- error_free(E);
+ error_free_or_abort(&E);
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <1487362554-5688-1-git-send-email-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
-rw-r--r-- | tests/test-qemu-opts.c | 3 | ||||
-rw-r--r-- | tests/test-qobject-output-visitor.c | 6 |
2 files changed, 3 insertions, 6 deletions
diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c index f6310b34f1..0ad74b464f 100644 --- a/tests/test-qemu-opts.c +++ b/tests/test-qemu-opts.c @@ -93,8 +93,7 @@ static void test_find_unknown_opts(void) /* should not return anything, we don't have an "unknown" option */ list = qemu_find_opts_err("unknown", &err); g_assert(list == NULL); - g_assert(err); - error_free(err); + error_free_or_abort(&err); } static void test_qemu_find_opts(void) diff --git a/tests/test-qobject-output-visitor.c b/tests/test-qobject-output-visitor.c index 500b452d98..c213fceeb3 100644 --- a/tests/test-qobject-output-visitor.c +++ b/tests/test-qobject-output-visitor.c @@ -145,8 +145,7 @@ static void test_visitor_out_enum_errors(TestOutputVisitorData *data, for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) { err = NULL; visit_type_EnumOne(data->ov, "unused", &bad_values[i], &err); - g_assert(err); - error_free(err); + error_free_or_abort(&err); visitor_reset(data); } } @@ -244,8 +243,7 @@ static void test_visitor_out_struct_errors(TestOutputVisitorData *data, u.has_enum1 = true; u.enum1 = bad_values[i]; visit_type_UserDefOne(data->ov, "unused", &pu, &err); - g_assert(err); - error_free(err); + error_free_or_abort(&err); visitor_reset(data); } } |