aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCole Robinson <crobinso@redhat.com>2015-05-05 11:07:18 -0400
committerGerd Hoffmann <kraxel@redhat.com>2015-05-20 10:23:08 +0200
commitbc119048d7377ec8335ecde5946df629a1b72b46 (patch)
treeeca9ff9a7abb1cba7dc61617fb7f977ad4419fd4
parent3d00ac1a2ee0294fc3d460e6013a5cdd9c73ea6c (diff)
vnc: Tweak error when init fails
Before: qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server on `(null)': Failed to bind socket to /root/foo.sock: Permission denied After: qemu-system-x86_64: -display vnc=unix:/root/foo.sock: Failed to start VNC server: Failed to bind socket to /root/foo.sock: Permission denied Rather than tweak the string possibly show unix: value as well, just drop the explicit display reporting. We already get the cli string in the error message, that should be sufficient. Signed-off-by: Cole Robinson <crobinso@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
-rw-r--r--ui/vnc.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/ui/vnc.c b/ui/vnc.c
index fe4cd759a1..1013ea5c45 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3779,8 +3779,7 @@ int vnc_init_func(QemuOpts *opts, void *opaque)
vnc_display_init(id);
vnc_display_open(id, &local_err);
if (local_err != NULL) {
- error_report("Failed to start VNC server on `%s': %s",
- qemu_opt_get(opts, "display"),
+ error_report("Failed to start VNC server: %s",
error_get_pretty(local_err));
error_free(local_err);
exit(1);