aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2018-03-07 14:02:38 +0100
committerMichael Roth <mdroth@linux.vnet.ibm.com>2018-06-20 20:44:59 -0500
commitcebb7fea7cf10b347b8a76448788779ad32e63f8 (patch)
treeac1ea9b51db9f0427e08f6968433c495802e394b
parentaedaf01f8c8197823a21e76481c8e4de5cf257d3 (diff)
memory: fix flatview_access_valid RCU read lock/unlock imbalance
Fixes: 11e732a5ed46903f997985bed4c3767ca28a7eb6 Reported-by: Cornelia Huck <cohuck@redhat.com> Reported-by: luigi burdo <intermediadc@hotmail.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Tested-by: Cornelia Huck <cohuck@redhat.com> Tested-by: Thomas Huth <thuth@redhat.com> Message-id: 20180307130238.19358-1-pbonzini@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org> (cherry picked from commit b39b61e410022f96ceb53d4381d25cba5126ac44) Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
-rw-r--r--exec.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/exec.c b/exec.c
index d589283bdd..5f8017a5d7 100644
--- a/exec.c
+++ b/exec.c
@@ -3320,7 +3320,6 @@ static bool flatview_access_valid(FlatView *fv, hwaddr addr, int len,
if (!memory_access_is_direct(mr, is_write)) {
l = memory_access_size(mr, l, addr);
if (!memory_region_access_valid(mr, xlat, l, is_write)) {
- rcu_read_unlock();
return false;
}
}