aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2015-03-11 13:21:06 +0000
committerPeter Maydell <peter.maydell@linaro.org>2015-03-11 13:21:06 +0000
commit4f9950520a115acf9c0a209f0befa45758ad0215 (patch)
tree49a311b1a3f68942a4fb0a095c10fe227661b219
parent83d0cf895f9b1c35fb56d3c93fd3504bc1ac8344 (diff)
bitops.h: sextract64() return type should be int64_t, not uint64_t
The documentation for sextract64() claims that the return type is an int64_t, but the code itself disagrees. Fix the return type to conform to the documentation and to bring it into line with sextract32(), which returns int32_t. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <rth@twiddle.net> Message-id: 1423231328-15662-1-git-send-email-peter.maydell@linaro.org
-rw-r--r--include/qemu/bitops.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h
index 181bd46063..90ca8df4e2 100644
--- a/include/qemu/bitops.h
+++ b/include/qemu/bitops.h
@@ -354,7 +354,7 @@ static inline int32_t sextract32(uint32_t value, int start, int length)
* Returns: the sign extended value of the bit field extracted from the
* input value.
*/
-static inline uint64_t sextract64(uint64_t value, int start, int length)
+static inline int64_t sextract64(uint64_t value, int start, int length)
{
assert(start >= 0 && length > 0 && length <= 64 - start);
/* Note that this implementation relies on right shift of signed