aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAvi Kivity <avi@redhat.com>2011-08-01 11:04:39 +0300
committerAvi Kivity <avi@redhat.com>2011-09-04 17:46:51 +0300
commit72124c01c614ab114134a42c1d8147fc7adeeb8c (patch)
tree23049d3346a84b9abf77eca971ca5d3856597553
parent64c048f4a86d92078970ca5d817fd6411430b6a0 (diff)
piix_pci: wrap memory update in a transaction
The code will remap all PAMs, even if just one is updated, resulting in reduced performance. Wrap in a transaction to detect that those other PAMs have not changed. Reviewed-by: Richard Henderson <rth@twiddle.net> Signed-off-by: Avi Kivity <avi@redhat.com>
-rw-r--r--hw/piix_pci.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index f892994eae..8f6ea42e2c 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -142,6 +142,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
int i, r;
uint32_t smram;
+ memory_region_transaction_begin();
update_pam(d, 0xf0000, 0x100000, (d->dev.config[I440FX_PAM] >> 4) & 3,
&d->pam_regions[0]);
for(i = 0; i < 12; i++) {
@@ -162,6 +163,7 @@ static void i440fx_update_memory_mappings(PCII440FXState *d)
d->smram_enabled = false;
}
}
+ memory_region_transaction_commit();
}
static void i440fx_set_smm(int val, void *arg)