aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaolo Bonzini <pbonzini@redhat.com>2015-09-14 12:31:44 +0200
committerRiku Voipio <riku.voipio@linaro.org>2015-10-01 11:43:42 +0300
commit86abac06c142d20772b3f2e04c9bf02b7936a0b3 (patch)
treec271a60f1c3bbcd0912d970a7bd2700bc6c85b4f
parentd0924a26d8f37ab95fdef99f6850b93e9af3ffb2 (diff)
linux-user: assert that target_mprotect cannot fail
All error conditions that target_mprotect checks are also checked by target_mmap. EACCESS cannot happen because we are just removing PROT_WRITE. ENOMEM should not happen because we are modifying a whole VMA (and we have bigger problems anyway if it happens). Fixes a Coverity false positive, where Coverity complains about target_mprotect's return value being passed to tb_invalidate_phys_range. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
-rw-r--r--linux-user/mmap.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index b2126c76fa..5606bcd164 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -514,10 +514,7 @@ abi_long target_mmap(abi_ulong start, abi_ulong len, int prot,
goto fail;
if (!(prot & PROT_WRITE)) {
ret = target_mprotect(start, len, prot);
- if (ret != 0) {
- start = ret;
- goto the_end;
- }
+ assert(ret == 0);
}
goto the_end;
}