diff options
| author | Jeff Cody <jcody@redhat.com> | 2012-09-25 12:29:39 -0400 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2012-09-28 17:51:47 +0200 |
| commit | 870f5681c9dbafc738082b1fd48e0cc013bf43c7 (patch) | |
| tree | 1bc7e51832d85827111a3d710e692b83b587d7ce | |
| parent | 946d58be1533bf843b499df12e1d9f97b28245c8 (diff) | |
block: after creating a live snapshot, make old image read-only
Currently, after a live snapshot of a drive, the image that has
been 'demoted' to be below the new active layer remains r/w.
This patch reopens it read-only.
Note that we do not check for error on the reopen(), because we
will not abort the snapshots if the reopen fails.
This patch depends on the bdrv_reopen() series.
Signed-off-by: Jeff Cody <jcody@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | blockdev.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/blockdev.c b/blockdev.c index e5d450f0bb..0267fa30bf 100644 --- a/blockdev.c +++ b/blockdev.c @@ -805,6 +805,11 @@ void qmp_transaction(BlockdevActionList *dev_list, Error **errp) QSIMPLEQ_FOREACH(states, &snap_bdrv_states, entry) { /* This removes our old bs from the bdrv_states, and adds the new bs */ bdrv_append(states->new_bs, states->old_bs); + /* We don't need (or want) to use the transactional + * bdrv_reopen_multiple() across all the entries at once, because we + * don't want to abort all of them if one of them fails the reopen */ + bdrv_reopen(states->new_bs, states->new_bs->open_flags & ~BDRV_O_RDWR, + NULL); } /* success */ |