diff options
| author | Peter Xu <peterx@redhat.com> | 2016-03-09 13:56:37 +0800 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2016-03-30 11:59:32 +0200 |
| commit | 5eda622768a2162993e50275b325125d4485757d (patch) | |
| tree | 010635ff8fb5da4b326bd08ada6dec14a9f377e3 | |
| parent | 853ccfed8fe40ba97c4814b5165fda4cfeee044b (diff) | |
block/qapi: fix unbounded stack for dump_qdict
Using heap instead of stack for better safety.
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| -rw-r--r-- | block/qapi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/block/qapi.c b/block/qapi.c index e0e6e96ad2..1961cdf707 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -669,7 +669,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); - char key[strlen(entry->key) + 1]; + char *key = g_malloc(strlen(entry->key) + 1); int i; /* replace dashes with spaces in key (variable) names */ @@ -683,6 +683,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, if (!composite) { func_fprintf(f, "\n"); } + g_free(key); } } |