aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEduardo Habkost <ehabkost@redhat.com>2017-09-21 13:22:34 -0300
committerEduardo Habkost <ehabkost@redhat.com>2017-09-22 11:39:17 -0300
commit5810314e98c6e83b3334c451c7999fff7a27ef78 (patch)
treed6cbc571796182460393bbed12332058c96c4aee
parent9ee660e7c138595224b65ddc1c5712549f0a278c (diff)
qemu.py: Call logging.basicConfig() automatically
Not all scripts using qemu.py configure the Python logging module, and end up generating a "No handlers could be found for logger" message instead of actual log messages. To avoid requiring every script using qemu.py to configure logging manually, call basicConfig() when creating a QEMUMachine object. This won't affect scripts that already set up logging, but will ensure that scripts that don't configure logging keep working. Reported-by: Kevin Wolf <kwolf@redhat.com> Fixes: 4738b0a85a0c2031fddc71b51cccebce0c4ba6b1 Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20170921162234.847-1-ehabkost@redhat.com> Reviewed-by: Cleber Rosa <crosa@redhat.com> Acked-by: Lukáš Doktor <ldoktor@redhat.com> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
-rw-r--r--scripts/qemu.py3
1 files changed, 3 insertions, 0 deletions
diff --git a/scripts/qemu.py b/scripts/qemu.py
index 5e02dd8e78..73d6031e02 100644
--- a/scripts/qemu.py
+++ b/scripts/qemu.py
@@ -89,6 +89,9 @@ class QEMUMachine(object):
self._qmp = None
self._qemu_full_args = None
+ # just in case logging wasn't configured by the main script:
+ logging.basicConfig(level=(logging.DEBUG if debug else logging.WARN))
+
def __enter__(self):
return self