aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2014-03-27 10:54:17 +0000
committerPeter Maydell <peter.maydell@linaro.org>2014-03-27 10:54:17 +0000
commitbea4acda3bff00e98cb00d5354f23de9e74a928f (patch)
tree0fcc76ec56735b99521a6c53762bb59787920120
parentdb237e33c08a279f0179f8f5128a6d10d9adc38a (diff)
parent6a5b69a959483c7404576a7dc54221ced41e6515 (diff)
Merge remote-tracking branch 'remotes/mcayland/qemu-sparc' into staging
* remotes/mcayland/qemu-sparc: target-sparc: fix 32bit integer division overflow Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
-rw-r--r--target-sparc/helper.c17
1 files changed, 10 insertions, 7 deletions
diff --git a/target-sparc/helper.c b/target-sparc/helper.c
index f3c7fbf993..ae7740bca1 100644
--- a/target-sparc/helper.c
+++ b/target-sparc/helper.c
@@ -85,8 +85,8 @@ static target_ulong helper_udiv_common(CPUSPARCState *env, target_ulong a,
}
x0 = x0 / x1;
- if (x0 > 0xffffffff) {
- x0 = 0xffffffff;
+ if (x0 > UINT32_MAX) {
+ x0 = UINT32_MAX;
overflow = 1;
}
@@ -122,12 +122,15 @@ static target_ulong helper_sdiv_common(CPUSPARCState *env, target_ulong a,
if (x1 == 0) {
cpu_restore_state(CPU(cpu), GETPC());
helper_raise_exception(env, TT_DIV_ZERO);
- }
-
- x0 = x0 / x1;
- if ((int32_t) x0 != x0) {
- x0 = x0 < 0 ? 0x80000000 : 0x7fffffff;
+ } else if (x1 == -1 && x0 == INT64_MIN) {
+ x0 = INT32_MAX;
overflow = 1;
+ } else {
+ x0 = x0 / x1;
+ if ((int32_t) x0 != x0) {
+ x0 = x0 < 0 ? INT32_MIN : INT32_MAX;
+ overflow = 1;
+ }
}
if (cc) {