diff options
| author | John Snow <jsnow@redhat.com> | 2023-02-14 19:00:08 -0500 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2023-02-23 13:01:14 +0100 |
| commit | c60caf8086247afbfbf0673993d809d348238ef6 (patch) | |
| tree | aa73ac61c28514f8fb721ab11ee83b6fcf5f804a | |
| parent | 885ecdbec9da62ede8019fc74f9154215e410aee (diff) | |
qapi: Add minor typing workaround for 3.6
Pylint under 3.6 does not believe that Collection is subscriptable at
runtime. It is, making this a Pylint
bug. https://github.com/PyCQA/pylint/issues/2377
They closed it as fixed, but that doesn't seem to be true as of Pylint
2.13.9, the latest version you can install under Python 3.6. 2.13.9 was
released 2022-05-13, about seven months after the bug was closed.
The least-annoying fix here is to just use the concret type.
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20230215000011.1725012-4-jsnow@redhat.com>
[Dumbed down from Sequence[str] to List[str], commit message adjusted]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
| -rw-r--r-- | scripts/qapi/expr.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py index 5a1782b57e..358b8e2a8b 100644 --- a/scripts/qapi/expr.py +++ b/scripts/qapi/expr.py @@ -33,7 +33,6 @@ structures and contextual semantic validation. import re from typing import ( - Collection, Dict, Iterable, List, @@ -195,8 +194,8 @@ def check_defn_name_str(name: str, info: QAPISourceInfo, meta: str) -> None: def check_keys(value: _JSONObject, info: QAPISourceInfo, source: str, - required: Collection[str], - optional: Collection[str]) -> None: + required: List[str], + optional: List[str]) -> None: """ Ensure that a dict has a specific set of keys. |