aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Graf <agraf@suse.de>2010-05-26 21:04:32 +0200
committerAurelien Jarno <aurelien@aurel32.net>2010-05-27 00:08:09 +0200
commitc317728872ee9de44a1514bbe1f1fc8d5f8a7aeb (patch)
treefa826b48118bd11b8dae986a351abbe376de05bd
parentd63baf92e3e968626e0899ec6070e747a9bf51bf (diff)
Make cache=unsafe the default for -snapshot
When using -snapshot we don't care about data integrity of the cow file at all, so let's disable flushing there and squeeze out the last drop of performance we could possibly get. Signed-off-by: Alexander Graf <agraf@suse.de> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
-rw-r--r--qemu-options.hx6
-rw-r--r--vl.c4
2 files changed, 5 insertions, 5 deletions
diff --git a/qemu-options.hx b/qemu-options.hx
index cea9b72b2a..a6928b7aa3 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -170,8 +170,7 @@ the storage subsystem.
Writeback caching will report data writes as completed as soon as the data is
present in the host page cache. This is safe as long as you trust your host.
If your host crashes or loses power, then the guest may experience data
-corruption. When using the @option{-snapshot} option, writeback caching is
-used by default.
+corruption.
The host page cache can be avoided entirely with @option{cache=none}. This will
attempt to do disk IO directly to the guests memory. QEMU may still perform
@@ -185,7 +184,8 @@ In case you don't care about data integrity over host failures, use
cache=unsafe. This option tells qemu that it never needs to write any data
to the disk but can instead keeps things in cache. If anything goes wrong,
like your host losing power, the disk storage getting disconnected accidently,
-etc. you're image will most probably be rendered unusable.
+etc. you're image will most probably be rendered unusable. When using
+the @option{-snapshot} option, unsafe caching is always used.
Instead of @option{-cdrom} you can use:
@example
diff --git a/vl.c b/vl.c
index bc15dd74af..417554fc64 100644
--- a/vl.c
+++ b/vl.c
@@ -1105,9 +1105,9 @@ DriveInfo *drive_init(QemuOpts *opts, void *opaque,
return NULL;
}
if (snapshot) {
- /* always use write-back with snapshot */
+ /* always use cache=unsafe with snapshot */
bdrv_flags &= ~BDRV_O_CACHE_MASK;
- bdrv_flags |= (BDRV_O_SNAPSHOT|BDRV_O_CACHE_WB);
+ bdrv_flags |= (BDRV_O_SNAPSHOT|BDRV_O_CACHE_WB|BDRV_O_NO_FLUSH);
}
if (media == MEDIA_CDROM) {