aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJan Kiszka <jan.kiszka@siemens.com>2010-04-29 18:24:43 +0200
committerAnthony Liguori <aliguori@us.ibm.com>2010-05-03 12:09:48 -0500
commitd510c5cf343eabd4d3a301f5730af724747b7055 (patch)
tree0aff273089e54a6ab717ebc85bc4e315a3c42490
parent54eefd72bfc0ad7cd5cbedba8ef4368bd2bc3329 (diff)
Fix tiny leak in qemu_opts_parse
qemu_opts_create duplicates the id we pass in case it shall be stored in the opts. So we do not need to dup it in qemu_opts_parse, leaking a few bytes this way. Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
-rw-r--r--qemu-option.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/qemu-option.c b/qemu-option.c
index 1ffc497828..076dddfc02 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -763,10 +763,10 @@ QemuOpts *qemu_opts_parse(QemuOptsList *list, const char *params,
if (strncmp(params, "id=", 3) == 0) {
get_opt_value(value, sizeof(value), params+3);
- id = qemu_strdup(value);
+ id = value;
} else if ((p = strstr(params, ",id=")) != NULL) {
get_opt_value(value, sizeof(value), p+4);
- id = qemu_strdup(value);
+ id = value;
}
opts = qemu_opts_create(list, id, 1);
if (opts == NULL)