aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPeter Maydell <peter.maydell@linaro.org>2014-03-28 14:22:49 +0000
committerKevin Wolf <kwolf@redhat.com>2014-04-04 19:36:39 +0200
commit4d1cb6e6f51b0d8405f701806a203a73e7431fe5 (patch)
tree4f38889ded2d15ec5e832f547dc680149a644af9
parentf187743acd39747cc8cc32111518142c924963b9 (diff)
dma-helpers: Initialize DMAAIOCB in_cancel flag
Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() does not return zero-initialized memory. Spotted by the clang sanitizer (which complained when the value loaded in dma_complete() was not valid for a bool type); this might have resulted in leaking the AIO block. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
-rw-r--r--dma-helpers.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/dma-helpers.c b/dma-helpers.c
index c9620a5bbd..5f421e9814 100644
--- a/dma-helpers.c
+++ b/dma-helpers.c
@@ -213,6 +213,7 @@ BlockDriverAIOCB *dma_bdrv_io(
dbs->sg_cur_index = 0;
dbs->sg_cur_byte = 0;
dbs->dir = dir;
+ dbs->in_cancel = false;
dbs->io_func = io_func;
dbs->bh = NULL;
qemu_iovec_init(&dbs->iov, sg->nsg);