diff options
| author | Michael Roth <michael.roth@amd.com> | 2020-11-08 08:37:41 -0600 |
|---|---|---|
| committer | Michael Roth <michael.roth@amd.com> | 2020-11-09 14:07:14 -0600 |
| commit | b1b9ab1c04d560f86d8da3dfca4d8b21de75fee6 (patch) | |
| tree | 32a2f6e92a5d3e0019523cd9f073b2f2ac90e522 | |
| parent | 3493c36f0371777c62d1d72b205b0eb6117e2156 (diff) | |
qga: fix missing closedir() in qmp_guest_get_disks()
We opendir("/sys/block") at the beginning of the function, but we never
close it prior to returning.
Fixes: Coverity CID 1436130
Fixes: fed3956429d5 ("qga: add implementation of guest-get-disks for Linux")
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
Cc: Tomáš Golembiovský <tgolembi@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
| -rw-r--r-- | qga/commands-posix.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 3711080d07..12c1ba5ef7 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -1443,6 +1443,9 @@ GuestDiskInfoList *qmp_guest_get_disks(Error **errp) get_disk_deps(disk_dir, disk); ret = get_disk_partitions(ret, de->d_name, disk_dir, dev_name); } + + closedir(dp); + return ret; } |