diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-12-11 18:11:33 +0100 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-12-19 10:38:19 +0100 |
| commit | 436054e22f8447692196ddae7012f6083140e461 (patch) | |
| tree | 9565ada1065864b42ff5a31703065e09390c344c | |
| parent | 28f1c1f6e07c4bb4d79bed9474d1425c55e21712 (diff) | |
hmp: Simplify how qmp_human_monitor_command() gets output
Commit 48c043d0d1 "hmp: human-monitor-command: stop using the Memory
chardev driver" left us "if string is non-empty, duplicate it, else
duplicate the empty string". Meh. Duplicate it unconditionally.
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201211171152.146877-2-armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
| -rw-r--r-- | monitor/misc.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/monitor/misc.c b/monitor/misc.c index f2ee7cd77a..33d0dae2e8 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -136,11 +136,7 @@ char *qmp_human_monitor_command(const char *command_line, bool has_cpu_index, handle_hmp_command(&hmp, command_line); WITH_QEMU_LOCK_GUARD(&hmp.common.mon_lock) { - if (qstring_get_length(hmp.common.outbuf) > 0) { - output = g_strdup(qstring_get_str(hmp.common.outbuf)); - } else { - output = g_strdup(""); - } + output = g_strdup(qstring_get_str(hmp.common.outbuf)); } out: |