diff options
| author | dann frazier <dann.frazier@canonical.com> | 2011-09-21 14:06:25 -0600 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2011-09-23 10:55:32 -0500 |
| commit | dd8e93799f13ef82d83c185b8e71e049452f7d40 (patch) | |
| tree | 712e683c5dd95b8c5afc317a98c8398b607b0f2e | |
| parent | 74e26c179efa6eed821c2863b8a50c7b586432c4 (diff) | |
e1000: Don't set the Capabilities List bit
[Originally sent to qemu-kvm list, but I was redirected here]
The Capabilities Pointer is NULL, so this bit shouldn't be set. The state of
this bit doesn't appear to change any behavior on Linux/Windows versions we've
tested, but it does cause Windows' PCI/PCI Express Compliance Test to balk.
I happen to have a physical 82540EM controller, and it also sets the
Capabilities Bit, but it actually has items on the capabilities list to go
with it :)
Signed-off-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | hw/e1000.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/hw/e1000.c b/hw/e1000.c index 6a3a941488..ce8fc8b510 100644 --- a/hw/e1000.c +++ b/hw/e1000.c @@ -1151,8 +1151,6 @@ static int pci_e1000_init(PCIDevice *pci_dev) pci_conf = d->dev.config; - /* TODO: we have no capabilities, so why is this bit set? */ - pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_CAP_LIST); /* TODO: RST# value should be 0, PCI spec 6.2.4 */ pci_conf[PCI_CACHE_LINE_SIZE] = 0x10; |