aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCole Robinson <crobinso@redhat.com>2014-03-21 19:42:24 -0400
committerLuiz Capitulino <lcapitulino@redhat.com>2014-04-25 09:19:58 -0400
commit4ad417baa43424b6b988c52b83989fd95670c113 (patch)
tree5237e5e5e3eb78f894580829afaaacd696b7607a
parent4a66d3bf9ad3d121c32375081dc1379c3478fdb8 (diff)
error: Print error_report() to stderr if using qmp
monitor_printf will drop the requested output if cur_mon is qmp (for good reason). However these messages are often helpful for debugging issues with via libvirt. If we know the message won't hit the monitor, send it to stderr. Cc: Luiz Capitulino <lcapitulino@redhat.com> Cc: Markus Armbruster <armbru@redhat.com> Signed-off-by: Cole Robinson <crobinso@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
-rw-r--r--util/qemu-error.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/util/qemu-error.c b/util/qemu-error.c
index 80df49a874..7b167fd06b 100644
--- a/util/qemu-error.c
+++ b/util/qemu-error.c
@@ -20,7 +20,7 @@
*/
void error_vprintf(const char *fmt, va_list ap)
{
- if (cur_mon) {
+ if (cur_mon && !monitor_cur_is_qmp()) {
monitor_vprintf(cur_mon, fmt, ap);
} else {
vfprintf(stderr, fmt, ap);