diff options
author | Max Reitz <mreitz@redhat.com> | 2021-02-11 18:22:41 +0100 |
---|---|---|
committer | Max Reitz <mreitz@redhat.com> | 2021-03-29 18:09:00 +0200 |
commit | 53431b9086b2832ca1aeff0c55e186e9ed79bd11 (patch) | |
tree | 07ac004ddb909b39fa282df281d70cc1828bbb36 /.gdbinit | |
parent | 6d7bb95180b9313c8deb65671e65174205b1fd83 (diff) |
block/mirror: Fix mirror_top's permissions
mirror_top currently shares all permissions, and takes only the WRITE
permission (if some parent has taken that permission, too).
That is wrong, though; mirror_top is a filter, so it should take
permissions like any other filter does. For example, if the parent
needs CONSISTENT_READ, we need to take that, too, and if it cannot share
the WRITE permission, we cannot share it either.
The exception is when mirror_top is used for active commit, where we
cannot take CONSISTENT_READ (because it is deliberately unshared above
the base node) and where we must share WRITE (so that it is shared for
all images in the backing chain, so the mirror job can take it for the
target BB).
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210211172242.146671-2-mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Diffstat (limited to '.gdbinit')
0 files changed, 0 insertions, 0 deletions