diff options
author | Kegsay <kegan@matrix.org> | 2021-03-24 10:25:24 +0000 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-03-24 10:25:24 +0000 |
commit | af41f6d4549759afd7f52f780b40abe2834ab4c0 (patch) | |
tree | c13e5d27221981ac438e5880f5c93ae8999f596b /syncapi | |
parent | 802f1c96f804f7a146e4e12e25b20c980a6af870 (diff) |
Add Sentry support (#1803)
* Add Sentry support
* Use HTTP Sentry properly maybe
* Capture panics
* Log fed Sentry stuff correctly
* British english linter
Diffstat (limited to 'syncapi')
-rw-r--r-- | syncapi/consumers/clientapi.go | 3 | ||||
-rw-r--r-- | syncapi/consumers/eduserver_receipts.go | 3 | ||||
-rw-r--r-- | syncapi/consumers/eduserver_sendtodevice.go | 4 | ||||
-rw-r--r-- | syncapi/consumers/eduserver_typing.go | 2 | ||||
-rw-r--r-- | syncapi/consumers/keychange.go | 3 | ||||
-rw-r--r-- | syncapi/consumers/roomserver.go | 8 |
6 files changed, 23 insertions, 0 deletions
diff --git a/syncapi/consumers/clientapi.go b/syncapi/consumers/clientapi.go index 8dab513c..a166ae14 100644 --- a/syncapi/consumers/clientapi.go +++ b/syncapi/consumers/clientapi.go @@ -19,6 +19,7 @@ import ( "encoding/json" "github.com/Shopify/sarama" + "github.com/getsentry/sentry-go" "github.com/matrix-org/dendrite/internal" "github.com/matrix-org/dendrite/internal/eventutil" "github.com/matrix-org/dendrite/setup/config" @@ -78,6 +79,7 @@ func (s *OutputClientDataConsumer) onMessage(msg *sarama.ConsumerMessage) error if err := json.Unmarshal(msg.Value, &output); err != nil { // If the message was invalid, log it and move on to the next message in the stream log.WithError(err).Errorf("client API server output log: message parse failure") + sentry.CaptureException(err) return nil } @@ -90,6 +92,7 @@ func (s *OutputClientDataConsumer) onMessage(msg *sarama.ConsumerMessage) error context.TODO(), string(msg.Key), output.RoomID, output.Type, ) if err != nil { + sentry.CaptureException(err) log.WithFields(log.Fields{ "type": output.Type, "room_id": output.RoomID, diff --git a/syncapi/consumers/eduserver_receipts.go b/syncapi/consumers/eduserver_receipts.go index 59890807..668f945b 100644 --- a/syncapi/consumers/eduserver_receipts.go +++ b/syncapi/consumers/eduserver_receipts.go @@ -19,6 +19,7 @@ import ( "encoding/json" "github.com/Shopify/sarama" + "github.com/getsentry/sentry-go" "github.com/matrix-org/dendrite/eduserver/api" "github.com/matrix-org/dendrite/internal" "github.com/matrix-org/dendrite/setup/config" @@ -78,6 +79,7 @@ func (s *OutputReceiptEventConsumer) onMessage(msg *sarama.ConsumerMessage) erro if err := json.Unmarshal(msg.Value, &output); err != nil { // If the message was invalid, log it and move on to the next message in the stream log.WithError(err).Errorf("EDU server output log: message parse failure") + sentry.CaptureException(err) return nil } @@ -90,6 +92,7 @@ func (s *OutputReceiptEventConsumer) onMessage(msg *sarama.ConsumerMessage) erro output.Timestamp, ) if err != nil { + sentry.CaptureException(err) return err } diff --git a/syncapi/consumers/eduserver_sendtodevice.go b/syncapi/consumers/eduserver_sendtodevice.go index 668d3078..5e626aef 100644 --- a/syncapi/consumers/eduserver_sendtodevice.go +++ b/syncapi/consumers/eduserver_sendtodevice.go @@ -19,6 +19,7 @@ import ( "encoding/json" "github.com/Shopify/sarama" + "github.com/getsentry/sentry-go" "github.com/matrix-org/dendrite/eduserver/api" "github.com/matrix-org/dendrite/internal" "github.com/matrix-org/dendrite/setup/config" @@ -82,11 +83,13 @@ func (s *OutputSendToDeviceEventConsumer) onMessage(msg *sarama.ConsumerMessage) if err := json.Unmarshal(msg.Value, &output); err != nil { // If the message was invalid, log it and move on to the next message in the stream log.WithError(err).Errorf("EDU server output log: message parse failure") + sentry.CaptureException(err) return err } _, domain, err := gomatrixserverlib.SplitID('@', output.UserID) if err != nil { + sentry.CaptureException(err) return err } if domain != s.serverName { @@ -104,6 +107,7 @@ func (s *OutputSendToDeviceEventConsumer) onMessage(msg *sarama.ConsumerMessage) context.TODO(), output.UserID, output.DeviceID, output.SendToDeviceEvent, ) if err != nil { + sentry.CaptureException(err) log.WithError(err).Errorf("failed to store send-to-device message") return err } diff --git a/syncapi/consumers/eduserver_typing.go b/syncapi/consumers/eduserver_typing.go index 7d7ab3bf..c10d1e94 100644 --- a/syncapi/consumers/eduserver_typing.go +++ b/syncapi/consumers/eduserver_typing.go @@ -18,6 +18,7 @@ import ( "encoding/json" "github.com/Shopify/sarama" + "github.com/getsentry/sentry-go" "github.com/matrix-org/dendrite/eduserver/api" "github.com/matrix-org/dendrite/eduserver/cache" "github.com/matrix-org/dendrite/internal" @@ -83,6 +84,7 @@ func (s *OutputTypingEventConsumer) onMessage(msg *sarama.ConsumerMessage) error if err := json.Unmarshal(msg.Value, &output); err != nil { // If the message was invalid, log it and move on to the next message in the stream log.WithError(err).Errorf("EDU server output log: message parse failure") + sentry.CaptureException(err) return nil } diff --git a/syncapi/consumers/keychange.go b/syncapi/consumers/keychange.go index 0e1a790d..0d2ecd44 100644 --- a/syncapi/consumers/keychange.go +++ b/syncapi/consumers/keychange.go @@ -20,6 +20,7 @@ import ( "sync" "github.com/Shopify/sarama" + "github.com/getsentry/sentry-go" "github.com/matrix-org/dendrite/internal" "github.com/matrix-org/dendrite/keyserver/api" roomserverAPI "github.com/matrix-org/dendrite/roomserver/api" @@ -107,6 +108,7 @@ func (s *OutputKeyChangeEventConsumer) onMessage(msg *sarama.ConsumerMessage) er if err := json.Unmarshal(msg.Value, &output); err != nil { // If the message was invalid, log it and move on to the next message in the stream log.WithError(err).Error("syncapi: failed to unmarshal key change event from key server") + sentry.CaptureException(err) return err } // work out who we need to notify about the new key @@ -116,6 +118,7 @@ func (s *OutputKeyChangeEventConsumer) onMessage(msg *sarama.ConsumerMessage) er }, &queryRes) if err != nil { log.WithError(err).Error("syncapi: failed to QuerySharedUsers for key change event from key server") + sentry.CaptureException(err) return err } // make sure we get our own key updates too! diff --git a/syncapi/consumers/roomserver.go b/syncapi/consumers/roomserver.go index 85e73df6..a6aeee3a 100644 --- a/syncapi/consumers/roomserver.go +++ b/syncapi/consumers/roomserver.go @@ -20,6 +20,7 @@ import ( "fmt" "github.com/Shopify/sarama" + "github.com/getsentry/sentry-go" "github.com/matrix-org/dendrite/internal" "github.com/matrix-org/dendrite/roomserver/api" "github.com/matrix-org/dendrite/setup/config" @@ -148,18 +149,21 @@ func (s *OutputRoomEventConsumer) onNewRoomEvent( ev, err := s.updateStateEvent(ev) if err != nil { + sentry.CaptureException(err) return err } for i := range addsStateEvents { addsStateEvents[i], err = s.updateStateEvent(addsStateEvents[i]) if err != nil { + sentry.CaptureException(err) return err } } if msg.RewritesState { if err = s.db.PurgeRoomState(ctx, ev.RoomID()); err != nil { + sentry.CaptureException(err) return fmt.Errorf("s.db.PurgeRoom: %w", err) } } @@ -187,6 +191,7 @@ func (s *OutputRoomEventConsumer) onNewRoomEvent( if pduPos, err = s.notifyJoinedPeeks(ctx, ev, pduPos); err != nil { log.WithError(err).Errorf("Failed to notifyJoinedPeeks for PDU pos %d", pduPos) + sentry.CaptureException(err) return err } @@ -279,6 +284,7 @@ func (s *OutputRoomEventConsumer) onNewInviteEvent( } pduPos, err := s.db.AddInviteEvent(ctx, msg.Event) if err != nil { + sentry.CaptureException(err) // panic rather than continue with an inconsistent database log.WithFields(log.Fields{ "event_id": msg.Event.EventID(), @@ -300,6 +306,7 @@ func (s *OutputRoomEventConsumer) onRetireInviteEvent( ) error { pduPos, err := s.db.RetireInviteEvent(ctx, msg.EventID) if err != nil { + sentry.CaptureException(err) // panic rather than continue with an inconsistent database log.WithFields(log.Fields{ "event_id": msg.EventID, @@ -320,6 +327,7 @@ func (s *OutputRoomEventConsumer) onNewPeek( ) error { sp, err := s.db.AddPeek(ctx, msg.RoomID, msg.UserID, msg.DeviceID) if err != nil { + sentry.CaptureException(err) // panic rather than continue with an inconsistent database log.WithFields(log.Fields{ log.ErrorKey: err, |