diff options
author | Till <2353100+S7evinK@users.noreply.github.com> | 2023-02-07 14:31:23 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-07 14:31:23 +0100 |
commit | eb29a315507f0075c2c6a495ac59c64a7f45f9fc (patch) | |
tree | 3ed37d947dbacdf95c77dc27e4193c671e4968dc /roomserver/storage/postgres/events_table.go | |
parent | cf254ba0445e2509f77f41dbec69f632b126b847 (diff) |
Optimize `/sync` and history visibility (#2961)
Should fix the following issues or make a lot less worse when using
Postgres:
The main issue behind #2911: The client gives up after a certain time,
causing a cascade of context errors, because the response couldn't be
built up fast enough. This mostly happens on accounts with many rooms,
due to the inefficient way we're getting recent events and current state
For #2777: The queries for getting the membership events for history
visibility were being executed for each room (I think 185?), resulting
in a whooping 2k queries for membership events. (Getting the
statesnapshot -> block nids -> actual wanted membership event)
Both should now be better by:
- Using a LATERAL join to get all recent events for all joined rooms in
one go (TODO: maybe do the same for room summary and current state etc)
- If we're lazy loading on initial syncs, we're now not getting the
whole current state, just to drop the majority of it because we're lazy
loading members - we add a filter to exclude membership events on the
first call to `CurrentState`.
- Using an optimized query to get the membership events needed to
calculate history visibility
---------
Co-authored-by: kegsay <kegan@matrix.org>
Diffstat (limited to 'roomserver/storage/postgres/events_table.go')
-rw-r--r-- | roomserver/storage/postgres/events_table.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/roomserver/storage/postgres/events_table.go b/roomserver/storage/postgres/events_table.go index 9b5ed6ed..f4a21c8a 100644 --- a/roomserver/storage/postgres/events_table.go +++ b/roomserver/storage/postgres/events_table.go @@ -69,6 +69,9 @@ CREATE TABLE IF NOT EXISTS roomserver_events ( auth_event_nids BIGINT[] NOT NULL, is_rejected BOOLEAN NOT NULL DEFAULT FALSE ); + +-- Create an index which helps in resolving membership events (event_type_nid = 5) - (used for history visibility) +CREATE INDEX IF NOT EXISTS roomserver_events_memberships_idx ON roomserver_events (room_nid, event_state_key_nid) WHERE (event_type_nid = 5); ` const insertEventSQL = "" + |