diff options
| author | kegsay <kegan@matrix.org> | 2022-05-17 13:23:35 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-17 13:23:35 +0100 |
| commit | 6de29c1cd23d218f04d2e570932db8967d6adc4f (patch) | |
| tree | b95fa478ef9ecd2c21963868a3626063bdff7cbc /federationapi/federationapi.go | |
| parent | cd82460513d5abf04e56c01667d56499d4c354be (diff) | |
bugfix: E2EE device keys could sometimes not be sent to remote servers (#2466)
* Fix flakey sytest 'Local device key changes get to remote servers'
* Debug logs
* Remove internal/test and use /test only
Remove a lot of ancient code too.
* Use FederationRoomserverAPI in more places
* Use more interfaces in federationapi; begin adding regression test
* Linting
* Add regression test
* Unbreak tests
* ALL THE LOGS
* Fix a race condition which could cause events to not be sent to servers
If a new room event which rewrites state arrives, we remove all joined hosts
then re-calculate them. This wasn't done in a transaction so for a brief period
we would have no joined hosts. During this interim, key change events which arrive
would not be sent to destination servers. This would sporadically fail on sytest.
* Unbreak new tests
* Linting
Diffstat (limited to 'federationapi/federationapi.go')
| -rw-r--r-- | federationapi/federationapi.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/federationapi/federationapi.go b/federationapi/federationapi.go index bec9ac77..ff159bee 100644 --- a/federationapi/federationapi.go +++ b/federationapi/federationapi.go @@ -93,8 +93,8 @@ func AddPublicRoutes( // can call functions directly on the returned API or via an HTTP interface using AddInternalRoutes. func NewInternalAPI( base *base.BaseDendrite, - federation *gomatrixserverlib.FederationClient, - rsAPI roomserverAPI.RoomserverInternalAPI, + federation api.FederationClient, + rsAPI roomserverAPI.FederationRoomserverAPI, caches *caching.Caches, keyRing *gomatrixserverlib.KeyRing, resetBlacklist bool, |