diff options
author | Kegsay <kegan@matrix.org> | 2020-05-13 12:14:50 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-05-13 12:14:50 +0100 |
commit | 5e9dce1c0c66736937eeddd5c33c92700d9a65a7 (patch) | |
tree | e0c40667cb17714d160fba2fbc64470eedf9ca7b /README.md | |
parent | 31e6a7f1932c11d9b5b682ad06a5b8db9d74a44f (diff) |
syncapi: Rename and split out tokens (#1025)
* syncapi: Rename and split out tokens
Previously we used the badly named `PaginationToken` which was
used for both `/sync` and `/messages` requests. This quickly
became confusing because named fields like `PDUPosition` meant
different things depending on the token type. Instead, we now have
two token types: `TopologyToken` and `StreamingToken`, both of
which have fields which make more sense for their specific situations.
Updated the codebase to use one or the other. `PaginationToken` still
lives on as `syncToken`, an unexported type which both tokens rely on.
This allows us to guarantee that the specific mappings of positions
to a string remain solely under the control of the `types` package.
This enables us to move high-level conceptual things like
"decrement this topological token" to function calls e.g
`TopologicalToken.Decrement()`.
Currently broken because `/messages` seemingly used both stream and
topological tokens, though I need to confirm this.
* final tweaks/hacks
* spurious logging
* Review comments and linting
Diffstat (limited to 'README.md')
0 files changed, 0 insertions, 0 deletions