1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
|
#!/usr/bin/env python3
#
# Copyright (c) 2018-2022 The Bitcoin Core developers
# Distributed under the MIT software license, see the accompanying
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
"""
Check the test suite naming conventions
"""
import re
import subprocess
import sys
def grep_boost_fixture_test_suite():
command = [
"git",
"grep",
"-E",
r"^BOOST_FIXTURE_TEST_SUITE\(",
"--",
"src/test/**.cpp",
"src/wallet/test/**.cpp",
]
return subprocess.check_output(command, universal_newlines=True, encoding="utf8")
def check_matching_test_names(test_suite_list):
not_matching = [
x
for x in test_suite_list
if re.search(r"/(.*?)\.cpp:BOOST_FIXTURE_TEST_SUITE\(\1, .*\)", x) is None
]
if len(not_matching) > 0:
not_matching = "\n".join(not_matching)
error_msg = (
"The test suite in file src/test/foo_tests.cpp should be named\n"
'"foo_tests". Please make sure the following test suites follow\n'
"that convention:\n\n"
f"{not_matching}\n"
)
print(error_msg)
return 1
return 0
def get_duplicates(input_list):
"""
From https://stackoverflow.com/a/9835819
"""
seen = set()
dupes = set()
for x in input_list:
if x in seen:
dupes.add(x)
else:
seen.add(x)
return dupes
def check_unique_test_names(test_suite_list):
output = [re.search(r"\((.*?),", x) for x in test_suite_list]
output = [x.group(1) for x in output if x is not None]
output = get_duplicates(output)
output = sorted(list(output))
if len(output) > 0:
output = "\n".join(output)
error_msg = (
"Test suite names must be unique. The following test suite names\n"
f"appear to be used more than once:\n\n{output}"
)
print(error_msg)
return 1
return 0
def main():
test_suite_list = grep_boost_fixture_test_suite().splitlines()
exit_code = check_matching_test_names(test_suite_list)
exit_code |= check_unique_test_names(test_suite_list)
sys.exit(exit_code)
if __name__ == "__main__":
main()
|
