aboutsummaryrefslogtreecommitdiff
path: root/test/sanitizer_suppressions
AgeCommit message (Collapse)Author
2023-08-01Merge bitcoin/bitcoin#28131: test: Add UBSan `-fsanitize=integer` ↵fanquake
suppressions for `src/secp256k1` subtree a7477744c5e1df56d3a1e9ab9fc400bfb0ef6ec3 Add UBSan `-fsanitize=integer` suppressions for `src/secp256k1` subtree (Hennadii Stepanov) Pull request description: Required for https://github.com/bitcoin/bitcoin/pull/27991 (see the [comment](https://github.com/bitcoin/bitcoin/pull/27991#issuecomment-1611472816)) and for the upcoming CMake-based build system. ACKs for top commit: MarcoFalke: lgtm ACK a7477744c5e1df56d3a1e9ab9fc400bfb0ef6ec3 Tree-SHA512: 602fa3ad22d3b0f6981a51358677d2347c92c4c9f59626b497af10f7ba828ede37227d8ee717f089bf33bde5efe0854d53acc89bea46f0955e62b7f22c454d05
2023-07-25suppressions: note that 'type:ClassName::MethodName' should be usedfanquake
Now that the symbolizer is back in play, suppressions can once-again be targeted to functions, rather than file-wide.
2023-07-23Add UBSan `-fsanitize=integer` suppressions for `src/secp256k1` subtreeHennadii Stepanov
2023-07-17fuzz: Bump FuzzedDataProvider.hMarcoFalke
From https://github.com/llvm/llvm-project/blob/fa8401f9bfe81f4853bf9b67bff42a2cebffc10f/compiler-rt/include/fuzzer/FuzzedDataProvider.h
2023-06-23test: Add implicit-signed-integer-truncation:*/include/c++/ suppressionMarcoFalke
2023-06-14refactor: Make m_count_with_* in CTxMemPoolEntry int64_t, drop UBSAN suppMarcoFalke
This is a refactor as long as no signed integer overflow appears. In normal operation and absent bugs, signed integer overflow should never happen in the touched code paths. The main benefit of this refactor is to drop the file-wide ubsan suppression unsigned-integer-overflow:txmempool.cpp. For now, this only changes the internal private representation and the publicly returned type remains uint64_t.
2023-06-12Remove txmempool implicit-integer-sign-change sanitizer suppressionsHennadii Stepanov
2023-05-15doc, test: Document steps to reproduce TSan warning for `libdb`Hennadii Stepanov
2023-04-21test: Remove unused sanitizer suppressionsMarcoFalke
* The GCC suppression was fixed in gcc-11, which is available on all LTS releases of Linux distros. * The feerate suppression was likely fixed and does not trigger anymore. If it was to trigger again, the underlying bug should be fixed instead of suppressing it. * The bench suppression does not trigger anymore. Also, add comments to tsan suppressions on how to reproduce.
2023-03-30sanitizers: remove GetRNGState lsan suppressionfanquake
I am no-longer seeing this. Can anyone recreate the false-positive?
2023-01-30Add xoroshiro128++ PRNGMartin Leitner-Ankerl
Xoroshiro128++ is a fast non-cryptographic random generator. Reference implementation is available at https://prng.di.unimi.it/ Co-Authored-By: Pieter Wuille <pieter@wuille.net>
2022-12-30Revert "test: Drop no longer needed `race:epoll_ctl` TSan suppression"MarcoFalke
This reverts commit a3f5e541523a843e834df1858e16f89188fe19a2.
2022-12-27test: Drop no longer needed `race:epoll_ctl` TSan suppressionHennadii Stepanov
2022-11-21test: Remove unused sanitizer suppressionsMacroFake
2022-11-16refactor: Inline `CTxMemPoolEntry` class's functionsHennadii Stepanov
2022-11-16refactor: Move `CTxMemPoolEntry` class to its own moduleHennadii Stepanov
This change nukes the policy/fees->mempool circular dependency. Easy to review using `diff --color-moved=dimmed-zebra`.
2022-09-09scripted-diff: rename CChainState -> ChainstateJames O'Beirne
-BEGIN VERIFY SCRIPT- sed -i 's/CChainState/Chainstate/g' $(git grep -l CChainState ':(exclude)doc/release-notes*') -END VERIFY SCRIPT- Co-authored-by: MacroFake <falke.marco@gmail.com>
2022-06-22Fix signed integer overflow in prioritisetransaction RPCMarcoFalke
2022-02-25addrman: Log too low compat valueMarcoFalke
Also remove uint8_t{} casts from values that are already of the same type.
2022-02-25Avoid implicit-integer-sign-change in bech32.cppMarcoFalke
2022-02-25test: Remove no longer needed suppressionsMarcoFalke
2022-02-23test: Fix intermittent Tsan issueMarcoFalke
2022-02-19test: Remove suppression no longer needed with headers-only Boost.TestHennadii Stepanov
2022-02-14Merge bitcoin/bitcoin#24301: build: header-only Boostfanquake
5d399f9f3df513a0400049238f5ef0ef2352d57e build: remove native B2 package (fanquake) 2037a3b6c1222d2802ff7c8463f2bb79ba8b57d8 build: header-only Boost (fanquake) 39e66e938fb688f5400ad94a1b317fcc2a87bc31 build: use header-only Boost unit test (fanquake) Pull request description: This PR converts our Boost usage to header only. We switch from using our last remaining Boost lib (unit test), to using it's header-only implementation (see https://www.boost.org/doc/libs/1_78_0/libs/test/doc/html/boost_test/adv_scenarios/single_header_customizations/multiple_translation_units.html). Also related to #24291. Guix build: ```bash ``` ACKs for top commit: hebasto: re-ACK 5d399f9f3df513a0400049238f5ef0ef2352d57e MarcoFalke: approach ACK 5d399f9f3df513a0400049238f5ef0ef2352d57e 📞 Tree-SHA512: e60835ee9c11aa941a64679616da2002d6cd86e464895372fafdd42ad6499d7eb1dde6f0013c60adaeb97bd191198430cb158a7a7417b38080dd7106b28e3ba5
2022-02-13build: use header-only Boost unit testfanquake
2022-02-11refactor: Avoid unsigned integer overflow in core_writeMarcoFalke
2022-02-09test: Remove unused integer sanitizer suppressionsMarcoFalke
2022-02-07Fix integer sanitizer suppressions in validation.cppMarcoFalke
2022-02-02test: Avoid testing negative block heightsMarcoFalke
2022-02-02Merge bitcoin/bitcoin#24219: Fix implicit-integer-sign-change in bloomMarcoFalke
fad84a25956ec081f22aebbda309d168a3dc0004 refactor: Fixup uint64_t-cast style in touched line (MarcoFalke) fa041878de786f5be74ec74a06ec407c99ca8656 Fix implicit-integer-sign-change in bloom (MarcoFalke) Pull request description: Signed values don't really make sense when using `std::vector::operator[]`. Fix that and remove the suppression. ACKs for top commit: PastaPastaPasta: utACK fad84a25956ec081f22aebbda309d168a3dc0004 theStack: Code-review ACK fad84a25956ec081f22aebbda309d168a3dc0004 Tree-SHA512: 7139dd9aa098c41e4af1b6e63dd80e71a92b0a98062d1676b01fe550ffa8e21a5f84a578afa7a536d70dad1b8a5017625e3a9e2dda6f864b452ec77b130ddf2a
2022-02-01Merge bitcoin/bitcoin#24218: zmq: Fix implicit-integer-sign-changeMarcoFalke
fa2406a50a83184d101d1bb3f2b282ae280370ba zmq: Fix implicit-integer-sign-change (MarcoFalke) Pull request description: uint256::begin() returns unsigned data, so there is no reason to make it signed. Fix that and remove the sanitizer suppression. ACKs for top commit: hebasto: ACK fa2406a50a83184d101d1bb3f2b282ae280370ba PastaPastaPasta: utACK fa2406a50a83184d101d1bb3f2b282ae280370ba, I have reviewed the code and think it makes sense Tree-SHA512: 150ebcf3fdc3e0f60b6fd8e5fe638737b01e8a0863296bd545fb5ed17d33ab23b2ff94204996aa7b4617650b7383bd86ed2d2bf46746b410feae449de179a2bd
2022-02-01Merge bitcoin/bitcoin#24190: test: Fix sanitizer suppresions in streams_testsMarcoFalke
faa630aa15bbda0f3b0cf3b6f31cf8fdaeb66975 test: Fix sanitizer suppresions in streams_tests (MarcoFalke) Pull request description: Two changes (that also make sense on their own) to remove the file-wide sanitizer suppression: * `FindByte` no longer takes a `char`, but an `uint8_t`, after commit 196b4599201dbce3e0317e9b98753fa6a244b82d. * The `key` vector of unsigned chars can be removed and inlined as initializer-list. This avoids a bunch of verbose code like `clear()` and `push_back` of `char`s. ACKs for top commit: PastaPastaPasta: utACK faa630aa15bbda0f3b0cf3b6f31cf8fdaeb66975, I have reviewed the changes and agree it makes sense to merge Tree-SHA512: 747b9d4676fad6d07f3955668639c93333625e69199ff4c499f01167de3875990d93db85e775a7f5b1b684575dceaec8aa000b4db15525fc47b699bac1c85e3d
2022-01-31Fix implicit-integer-sign-change in bloomMarcoFalke
2022-01-31zmq: Fix implicit-integer-sign-changeMarcoFalke
2022-01-31refactor: Make MessageBoxFlags enum underlying type unsignedMarcoFalke
2022-01-31Merge bitcoin/bitcoin#24146: Avoid integer sanitizer warnings in chain.oMarcoFalke
fa832103aaa61e93b78ece9dd68c245a41afa6b6 Avoid integer sanitizer warnings in chain.o (MarcoFalke) Pull request description: The two changes make the code more self-documenting and also allow to remove 5 file-wide suppressions for the module ACKs for top commit: PastaPastaPasta: utACK fa832103aaa61e93b78ece9dd68c245a41afa6b6 jonatack: ACK fa832103aaa61e93b78ece9dd68c245a41afa6b6 Tree-SHA512: d32a06099c56eed9f69130a3209f989872acc593f849528acd7746ee6caa96688cc32de37e8e59ad5d25dcb8912e341f1a43e50642dadeff6ca7624d0873ad10
2022-01-28Merge bitcoin/bitcoin#24139: Avoid unsigned integer overflow in bitcoin-txMarcoFalke
faa75fa19335e3e826efa4f2280609a2db34425d Avoid unsigned integer overflow in bitcoin-tx (MarcoFalke) Pull request description: While `npos` means "largest unsigned value" and adding `1` to it yields `0`, it may be clearer to just assign `0` to it and only increment otherwise. This also allows to remove a file-wide suppression for `unsigned-integer-overflow`. ACKs for top commit: hebasto: ACK faa75fa19335e3e826efa4f2280609a2db34425d, I have reviewed the code and it looks OK, I agree it can be merged. theStack: Code-review ACK faa75fa19335e3e826efa4f2280609a2db34425d Tree-SHA512: c24436641e5d801341c948b812c7f711d5dff70efdf04af00fd3221f4b81d93f25608dddaa36230ba81ca7ab0d18bdd957095d4561e22621e4d69017934f0a16
2022-01-28test: Fix sanitizer suppresions in streams_testsMarcoFalke
2022-01-25test: remove unused sanitizer suppressionsMarcoFalke
2022-01-25Avoid integer sanitizer warnings in chain.oMarcoFalke
2022-01-24Avoid unsigned integer overflow in bitcoin-txMarcoFalke
2022-01-20refactor tests to fix ubsan suppressionsMarcoFalke
2022-01-17Merge bitcoin/bitcoin#24059: Fix implicit-integer-sign-change in arith_uint256MarcoFalke
fa99e108e778b5169b3de2ce557af68f1fe0ac0b Fix implicit-integer-sign-change in arith_uint256 (MarcoFalke) Pull request description: This refactor doesn't change behaviour, but clarifies that the numbers being dealt with aren't supposed to be negative. This helps when reading the code and allows to remove a sanitizer suppression for the whole file. ACKs for top commit: PastaPastaPasta: utACK fa99e108e778b5169b3de2ce557af68f1fe0ac0b shaavan: ACK fa99e108e778b5169b3de2ce557af68f1fe0ac0b Tree-SHA512: f227e2fd22021e39f0445ec041f4a299d13477c23cef0fc06c53fb3313cbe550cec329336224a7e8775d9045b8009423052b394e83d42a1e40772085dfcdd471
2022-01-13Fix implicit-integer-sign-change in arith_uint256MarcoFalke
2022-01-10fuzz: Limit fuzzed time to years 2000-2100MarcoFalke
2022-01-04refactor: Remove pointless and confusing shift in RelayAddressMarcoFalke
2022-01-04test: Bundle all integer sanitizer suppressions of dependenciesMarcoFalke
And remove three that are no longer needed. Can be reviewed with --color-moved=dimmed-zebra
2022-01-04Update test/sanitizer_suppressions/lsanHennadii Stepanov
2022-01-02Merge bitcoin/bitcoin#23795: refactor: Remove implicit-integer-sign-change ↵MarcoFalke
suppressions in validation fadd73037e266edb844f0972e82e9213171ef214 refactor: Remove implicit-integer-sign-change suppressions in validation.cpp (MarcoFalke) Pull request description: A file-wide suppression is problematic because it will wave through future violations, potentially bugs. Fix that by using per-statement casts. ACKs for top commit: shaavan: ACK fadd73037e266edb844f0972e82e9213171ef214 theStack: Code-review ACK fadd73037e266edb844f0972e82e9213171ef214 Tree-SHA512: a8a05613be35382b92d7970f958a4e8f4332432056eaa9d72f6719495134b93aaaeea692899d9035654d0e0cf56bcd759671eeeacfd0535582c0ea048ab58a56
2021-12-24test: Add missing suppressions for crypto_diff_fuzz_chacha20.cppMarcoFalke
generated by cgit v1.2.3 (git 2.26.2) at 2024-11-14 05:39:37 +0000