Age | Commit message (Collapse) | Author |
|
|
|
Move the txid duplicates check into BuildMerkleTree, where it can be done
much more efficiently (without needing to build a full txid set to detect
duplicates).
The previous version (using the std::set<uint256> to detect duplicates) was
also slightly too weak. A block mined with actual duplicate transactions
(which is invalid, due to the inputs of the duplicated transactions being
seen as double spends) would trigger the duplicates logic, resulting in the
block not being stored on disk, and rerequested. This change fixes that by
only triggering in the case of duplicated transactions that can actually
result in an identical merkle root.
|
|
head
|
|
87314c1 Fixing improper input syntax and failing bounds check (ENikS)
|
|
|
|
|
|
c8589bf Add actual signature tests (Pieter Wuille)
76ec867 Use actually valid transactions for script tests (Pieter Wuille)
|
|
|
|
- guard an unused variable with Q_UNUSED() macro
- remove a commented out line of code
|
|
|
|
|
|
4b0deb3 Clean up CMerkleTx::SetMerkleBranch. (Daniel Kraft)
|
|
5e83bc4 [Qt] include and file header cleanup (Philip Kaufmann)
|
|
6134b43 Fixing condition 'sabotaging' MSVC build (ENikS)
|
|
d6712db Also create pid file in non-daemon mode (Wladimir J. van der Laan)
|
|
It's strange to be able to close these windows while there is work
in progress.
Also set Qt::WA_DeleteOnClose on both windows to make sure that they
are deleted eventually, no matter what happens.
|
|
|
|
a49f11d qt: Change splash screen to normal window (Wladimir J. van der Laan)
|
|
01c2807 Add warning about the merkle-tree algorithm duplicate txid flaw (Peter Todd)
|
|
|
|
33a2771 test: Fix DoS tests after c74332c (Wladimir J. van der Laan)
|
|
20e01b1 Apply clang-format on some infrequently-updated files (Pieter Wuille)
|
|
Lots of people read the Bitcoin Core codebase to learn more about
crypto; better to warn about flaws explicitly so they don't blindly copy
the code for other uses and create broken systems.
|
|
Always make a pid file, not only when `-daemon` specified.
This is useful for troubleshooting, for attaching debuggers and loggers
and such.
- Write the pid file only after the datadir lock was acquired
- Don't create or remove a pid file on WIN32, and also don't show the option
|
|
Fix data structure mismatch ... The mind boggles that they were still passing at all.
|
|
ab15b2e Avoid copying undo data (Pieter Wuille)
|
|
|
|
|
|
|
|
- alphabetical ordering
- correct ordering own headers before normal headers etc.
|
|
Makes it possible to move, minimize, unminimize the window while
Bitcoin Core is initializing.
|
|
bbad683 [Qt] simplify return code and return values in txtablemodel (Philip Kaufmann)
21f1516 [Qt] add all used colors in txtablemodel to guiconstants (Philip Kaufmann)
|
|
- Remove spurious `pchCommand[1] = 1` in CMessageHeader()
- Make sure that pchCommand is zero-padded if length is shorter than
COMMAND_SIZE
- Use strnlen to determine length of pcmCommand in GetCommand
|
|
c15e483 typo fix of booleamn to boolean (imharrywu)
|
|
- only code movement
|
|
- also make parameter of CDBEnv::CheckpointLSN a constant reference
|
|
|
|
|
|
6dcfda2 Don't pass nHashType to EvalScript nor CheckSig (jtimon)
2b23a87 Don't pass nHashType to VerifyScript (jtimon)
ce3649fb Remove CScriptCheck::nHashType (was always 0) (jtimon)
358562b Remove unused function main:VerifySignature (jtimon)
|
|
1a61396 fix missing gettransaction entries in rpcclient (Benedict Chan)
57e1716 update rpc help message for gettransaction to add includeWatchonly param (Benedict Chan)
|
|
0be990b Move CTxDestination from script/script to script/standard (Pieter Wuille)
|
|
ee304b6 minor changes for help message of getpeerinfo (Philip Kaufmann)
|
|
|
|
e9992fb remove include of chainparams.h (imharrywu)
|
|
efad808 Avoid reject message feedback loops (Pieter Wuille)
|
|
f4fe205 add nModSize init to default constructor of CTxMemPoolEntry (Philip Kaufmann)
|
|
|
|
|
|
|
|
52a5f90 Create the common location for all m4 autotool build scripts, build-aux/m4.
|