aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2014-09-25Apply clang-format on crypto/* and compat/*Pieter Wuille
2014-09-24Do merkle root and txid duplicates check simultaneouslyPieter Wuille
Move the txid duplicates check into BuildMerkleTree, where it can be done much more efficiently (without needing to build a full txid set to detect duplicates). The previous version (using the std::set<uint256> to detect duplicates) was also slightly too weak. A block mined with actual duplicate transactions (which is invalid, due to the inputs of the duplicated transactions being seen as double spends) would trigger the duplicates logic, resulting in the block not being stored on disk, and rerequested. This change fixes that by only triggering in the case of duplicated transactions that can actually result in an identical merkle root.
2014-09-23Reinitializing list's begin iterator after few elements were erased from the ↵ENikS
head
2014-09-23Merge pull request #4955Pieter Wuille
87314c1 Fixing improper input syntax and failing bounds check (ENikS)
2014-09-23Avoiding referencing elements of an empty vectorENikS
2014-09-23Fixing out of bounds asses errorENikS
2014-09-23Merge pull request #4949Wladimir J. van der Laan
c8589bf Add actual signature tests (Pieter Wuille) 76ec867 Use actually valid transactions for script tests (Pieter Wuille)
2014-09-23Fixing out of bounds error in GetKey()ENikS
2014-09-23[Qt] minor changes in splashscreen.cppPhilip Kaufmann
- guard an unused variable with Q_UNUSED() macro - remove a commented out line of code
2014-09-22Add actual signature testsPieter Wuille
2014-09-22Use actually valid transactions for script testsPieter Wuille
2014-09-22Merge pull request #4787Wladimir J. van der Laan
4b0deb3 Clean up CMerkleTx::SetMerkleBranch. (Daniel Kraft)
2014-09-22Merge pull request #4852Wladimir J. van der Laan
5e83bc4 [Qt] include and file header cleanup (Philip Kaufmann)
2014-09-22Merge pull request #4947Wladimir J. van der Laan
6134b43 Fixing condition 'sabotaging' MSVC build (ENikS)
2014-09-22Merge pull request #4951Wladimir J. van der Laan
d6712db Also create pid file in non-daemon mode (Wladimir J. van der Laan)
2014-09-22qt: Make splash and shutdown window ignore close eventsWladimir J. van der Laan
It's strange to be able to close these windows while there is work in progress. Also set Qt::WA_DeleteOnClose on both windows to make sure that they are deleted eventually, no matter what happens.
2014-09-22remove code below asserts in limitedmap.h (fixes a ToDo)Philip Kaufmann
2014-09-22Merge pull request #4941Wladimir J. van der Laan
a49f11d qt: Change splash screen to normal window (Wladimir J. van der Laan)
2014-09-22Merge pull request #4952Wladimir J. van der Laan
01c2807 Add warning about the merkle-tree algorithm duplicate txid flaw (Peter Todd)
2014-09-21Fixing improper input syntax and failing bounds checkENikS
2014-09-21Merge pull request #4950Wladimir J. van der Laan
33a2771 test: Fix DoS tests after c74332c (Wladimir J. van der Laan)
2014-09-21Merge pull request #4933Pieter Wuille
20e01b1 Apply clang-format on some infrequently-updated files (Pieter Wuille)
2014-09-20Add warning about the merkle-tree algorithm duplicate txid flawPeter Todd
Lots of people read the Bitcoin Core codebase to learn more about crypto; better to warn about flaws explicitly so they don't blindly copy the code for other uses and create broken systems.
2014-09-20Also create pid file in non-daemon modeWladimir J. van der Laan
Always make a pid file, not only when `-daemon` specified. This is useful for troubleshooting, for attaching debuggers and loggers and such. - Write the pid file only after the datadir lock was acquired - Don't create or remove a pid file on WIN32, and also don't show the option
2014-09-20test: Fix DoS tests after c74332cWladimir J. van der Laan
Fix data structure mismatch ... The mind boggles that they were still passing at all.
2014-09-20Merge pull request #4835Pieter Wuille
ab15b2e Avoid copying undo data (Pieter Wuille)
2014-09-19Fixing condition 'sabotaging' MSVC buildENikS
2014-09-19Apply clang-format on some infrequently-updated filesPieter Wuille
2014-09-18Fixing 'vector out of bounds' issue in base 32 and 64ENikS
2014-09-18[Qt] include and file header cleanupPhilip Kaufmann
- alphabetical ordering - correct ordering own headers before normal headers etc.
2014-09-18qt: Change splash screen to normal windowWladimir J. van der Laan
Makes it possible to move, minimize, unminimize the window while Bitcoin Core is initializing.
2014-09-18Merge pull request #4667Wladimir J. van der Laan
bbad683 [Qt] simplify return code and return values in txtablemodel (Philip Kaufmann) 21f1516 [Qt] add all used colors in txtablemodel to guiconstants (Philip Kaufmann)
2014-09-18CMessageHeader sanity changesWladimir J. van der Laan
- Remove spurious `pchCommand[1] = 1` in CMessageHeader() - Make sure that pchCommand is zero-padded if length is shorter than COMMAND_SIZE - Use strnlen to determine length of pcmCommand in GetCommand
2014-09-18Merge pull request #4936Wladimir J. van der Laan
c15e483 typo fix of booleamn to boolean (imharrywu)
2014-09-18cleanup class private and public areas in walletdbPhilip Kaufmann
- only code movement
2014-09-18prefer const string& over char* in CDB and CWalletDB constructorPhilip Kaufmann
- also make parameter of CDBEnv::CheckpointLSN a constant reference
2014-09-18typo fix of booleamn to booleanimharrywu
2014-09-17Avoid copying undo dataPieter Wuille
2014-09-17Merge pull request #4555Wladimir J. van der Laan
6dcfda2 Don't pass nHashType to EvalScript nor CheckSig (jtimon) 2b23a87 Don't pass nHashType to VerifyScript (jtimon) ce3649fb Remove CScriptCheck::nHashType (was always 0) (jtimon) 358562b Remove unused function main:VerifySignature (jtimon)
2014-09-17Merge pull request #4863Wladimir J. van der Laan
1a61396 fix missing gettransaction entries in rpcclient (Benedict Chan) 57e1716 update rpc help message for gettransaction to add includeWatchonly param (Benedict Chan)
2014-09-17Merge pull request #4899Wladimir J. van der Laan
0be990b Move CTxDestination from script/script to script/standard (Pieter Wuille)
2014-09-16Merge pull request #4927Pieter Wuille
ee304b6 minor changes for help message of getpeerinfo (Philip Kaufmann)
2014-09-16Move CTxDestination from script/script to script/standardPieter Wuille
2014-09-16Merge pull request #4928Pieter Wuille
e9992fb remove include of chainparams.h (imharrywu)
2014-09-16Merge pull request #4903Pieter Wuille
efad808 Avoid reject message feedback loops (Pieter Wuille)
2014-09-16Merge pull request #4930Wladimir J. van der Laan
f4fe205 add nModSize init to default constructor of CTxMemPoolEntry (Philip Kaufmann)
2014-09-16add nModSize init to default constructor of CTxMemPoolEntryPhilip Kaufmann
2014-09-16fix missing gettransaction entries in rpcclientBenedict Chan
2014-09-16update rpc help message for gettransaction to add includeWatchonly paramBenedict Chan
2014-09-16Merge pull request #4719Wladimir J. van der Laan
52a5f90 Create the common location for all m4 autotool build scripts, build-aux/m4.