Age | Commit message (Collapse) | Author |
|
|
|
|
|
binaries
This change moves test data into the binaries rather than reading them from
the disk at runtime.
Advantages:
- Tests become distributable
- Cross-compile friendly. Build on one machine and execute in an arbitrary
location on another.
- Easier testing for backports. Users can verify that tests pass without having
to track down corresponding test data.
- More trustworthy test results and easier quality assurance as tests make
fewer assumptions about their environment.
- Tests could theoretically run at client/daemon startup and exit on failure.
Disadvantages:
- Required 'hexdump' build-dependency. This is a standard bsd tool that should
be usable everywhere. It is likely already installed on all build-machines.
- Tests can no longer be fudged after build by altering test-data.
|
|
More fixes for blockchain corruption on OSX.
|
|
libleveldb.a and libmemenv.a should be able to build in parallel, but in
practice calling the leveldb makefile ends up rewriting build_config.mk. If
one target tries to build while the other is halfway through writing the
.mk, the make ends up in an undefined state.
Fix that by making one depend on the other. This also reorders the variables
to be passed by param rather than via the environment, and combines the targets
into a single rule to avoid needless duplication.
|
|
As we'd previously learned, OSX's fsync is a data eating lie.
Since 0.8.4 we're still getting some reports of disk corruption on
OSX but now all of it looks like the block files have gotten out of
sync with the database. It turns out that we were still using fsync()
on the block files, so this isn't surprising.
|
|
Update translation process for autotools
|
|
|
|
Add BITCOIN_MM QR_CPP and BITCOIN_CPP in order to better accomodate complicated
targets. This is a no-op change.
|
|
|
|
|
|
|
|
Autoconf fixes
|
|
Longer term workaround for chainstate corruption from negative versions.
|
|
using relative directories from that point
|
|
to use any version other than 4.8 by default
|
|
|
|
- rename URL into URI in paymentserver where correct
- add some missing Qt-coding-stuff in paymentserver
- change QSpinBox to QLineEdit as base for BitcoinAmountField in .ui files
(as this is the result when converting the BAF back into base)
- remove some c_str() and replace with QString::fromStdString()
- remove several new-lines
- remove unneeded spaces
- indentation fixes
|
|
This also makes negative transaction versions non-standard.
This avoids an issue triggered in block 256818 where transactions with
negative version numbers were incorrectly serialized into the UTXO set.
On restart nodes detect the inconsistency and refuse to start so long as
a block with these transactions is inside the self-consistency check
window, logging "coin database inconsistencies found". The software
recommends reindexing, but reindexing does not correct the problem.
This should be fixed by changing the chainstate serialization, but
working around it seems harmless for now because the version is not
used by any network rule currently.
A patch free workaround is to start with -checklevel=2 which skips
the consistency checks, but the IsStandard change is important for
miners in order to protect unpatched nodes.
|
|
Don't warn about forks while fIsInitialDownload
|
|
Autotools buildsystem
|
|
qt: add vout index to transaction id in transactions details dialog
|
|
|
|
- removes all usages of PrintDebugStringF from Qt code
- ensure same format for all debug.log messages "functionname : Message"
|
|
|
|
|
|
Set Accept: application/bitcoin-paymentrequest header
|
|
|
|
RPC: add getrawchangeaddress, for raw transaction change destinations
|
|
[Qt] Display txfee in first sendCoinsDialog message box
|
|
|
|
[Qt] Handle address purpose in incremental updates
|
|
- prepend "Bitcoin-Qt" in front of debug.log entries, which come from Qt
- move DebugMessageHandler installation upwards to the event handler
installation, which fits much better
|
|
Signed-off-by: Jonas Schnelli <jonas.schnelli@include7.ch>
|
|
This is why we created this function. Avoids some #ifdef.
|
|
|
|
Bitcoin-Qt: fixes for using display unit from options
|
|
Correctly use the purpose of addresses that are added after the start
of the client. Addresses with purpose "refund" and "change" should not
be visible in the GUI. This is now handled correctly.
|
|
move Checkpoints:fEnabled from step 2 to step 3 in init
|
|
- extend PaymentServer with setOptionsModel() and rework initNetManager()
to make use of that
- fix all other places in the code to use display unit from options and no
hard-coded unit
|
|
|
|
Bitcoin-Qt: add testnet check and icon to intro dialog
|
|
[QT] Don't ask for a passphrase to getnewaddress.
|
|
Suggestion from BitPay: set an Accept: HTTP header when
fetching payment requests / payment ACKs.
|
|
CreateNewBlock / getblocktemplate cleaning
|
|
Document and test OP_RESERVED weirdness
|
|
|
|
Seems it was forgotten about when IsPushOnly() and the unittests were
written. A particular oddity is that OP_RESERVED doesn't count towards
the >201 opcode limit unlike every other named opcode.
|
|
Fix out-of-bounds check
|
|
- it belongs to parameter-to-internal flags step, not parameter
interactions phase
|