| Age | Commit message (Collapse) | Author |
|---|
|
NegateSignatureS is called with a signature without a hashtype, so
do not save the last byte and append it after S negation.
Updates the two tests which were affected by this bug.
|
|
2c0f901 [REST] rest/chaininfos add documentation (Jonas Schnelli)
59582c8 [REST] add /rest/chaininfos (Jonas Schnelli)
|
|
a651668 [Qt] prevent amount overflow problem with payment requests (Philip Kaufmann)
|
|
eb1c2cd Split logic to undo txin's off DisconnectBlock. (Daniel Kraft)
|
|
28ee7e8 Get rid of DetectShutdownThread (Wladimir J. van der Laan)
|
|
f4b2078 Replace difficulty readjustment blocks with Interval() (Shaul Kfir)
|
|
d67a642 [Qt] add bitcoin logo to about screen (Jonas Schnelli)
|
|
|
|
- as QDateTime.secsTo() returns a qint64 also store in a qint64 and not in
an integer
|
|
Normally bitcoin core does not display any network originated strings without
sanitizing or hex encoding. This wasn't done for strcommand in many places.
This could be used to play havoc with a terminal displaying the logs,
especially with printtoconsole in use.
Thanks to Evil-Knievel for reporting this issue.
|
|
cf008ac Acquire CCheckQueue's lock to avoid race condition (Suhas Daftuar)
|
|
A lot of times, disk corruption problems appear here.
To facilitate debugging and troubleshooting, add position information
to the error messages.
|
|
|
|
getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.
|
|
- rework the function to not log errors but use throw JSONRPCError
- remove a check for IsLocked() that is done in sendtoaddress and
sendfrom RPC calls already
- cache GetBalance() return value, because it's possibly used twice
|
|
35f7227 Clean up wallet encryption code. (Daniel Kraft)
|
|
Bitcoin amounts are stored as uint64 in the protobuf messages (see
paymentrequest.proto), but CAmount is defined as int64_t. Because
of that we need to verify that single and accumulated amounts are
in a valid range and no variable overflow has happened.
- fixes #5624 (#5622)
Thanks @SergioDemianLerner for reporting that issue and also supplying us
with a possible solution.
- add static verifyAmount() function to PaymentServer and move the logging
on error into the function
- also add a unit test to paymentservertests.cpp
|
|
7f991e3 c++11: These look like user-defined literals. (Cory Fields)
5a6155c c++11: don't forward-declare types used in maps (Cory Fields)
3447cf8 c++11: MOVEONLY: break circular dependency in wallet (Cory Fields)
bbacd88 c++11: MOVEONLY: move function definitions out of the header (Cory Fields)
a2b04dd build: fix newer boost build with c++11 (Cory Fields)
|
|
5ebe095 Trim RPC command table (Wladimir J. van der Laan)
4401b2d Removed main.h dependency from rpcserver.cpp (Eric Lombrozo)
|
|
Add a space to keep the compiler happy
|
|
|
|
c++11 (libc++'s stdlib implementation anyway) doesn't allow for map types to be
forward-declared. for example:
class foo;
std::map<int, foo> bar; // error, foo has not been defined.
class foo{};
Since CWallet and CWalletTx are inter-dependent, but only std::map<*,CWalletTx>
is used, forward-declare CWallet instead and define CWalletTx first.
Despite the mangled git diff, this change only amounts to moving ~320 lines in
a single chunk.
|
|
These need to be moved out of the header in order to resolve a circular
dependency between CWallet and CTxWallet. See next commit.
|
|
|
|
Instead, create a separate function that applies the undo operation of a
CTxInUndo object onto a CCoinsViewCache. This method is used from
DisconnectBlock.
|
|
This fixes a potential race condition in the CCheckQueueControl constructor,
which was looking directly at data in CCheckQueue without acquiring its lock.
Remove the now-unnecessary friendship for CCheckQueueControl
|
|
44e9a6b Update the 'test_IsStandard' unit test (Flavien Charlon)
a930658 Change the default maximum OP_RETURN size to 80 bytes (Flavien Charlon)
|
|
1371e6f Change "insane" to "absurd" (referring to high fees) in text strings and identifiers. (Daira Hopwood)
|
|
3ff735c Increase block download timeout base from 10 to 20 minutes. (Gregory Maxwell)
|
|
2d9b0b7 Fix priority calculation in CreateTransaction (Alex Morcos)
|
|
bf6cdeb Increase coverage of DERSIG edge cases (Pieter Wuille)
819bcf9 Add RPC test for DERSIG BIP switchover logic (Pieter Wuille)
5a47811 BIP66 changeover logic (Pieter Wuille)
092e9fe Example unit tests from BIP66 (Pieter Wuille)
80ad135 Change IsDERSignature to BIP66 implementation (Pieter Wuille)
|
|
fdf80ea [Qt] allow unit changes for read-only BitcoinAmountField (Philip Kaufmann)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
identifiers.
Note that this will also require translation changes in Transifex for the key
"A fee higher than %1 is considered an insanely high fee." which is now
"A fee higher than %1 is considered an absurdly high fee."
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
|
|
|
|
|
|
|
|
|
|
|
|
- fixes #5725
|
|
14d023f change hardcoded character constants to a set of descriptive named constants for database keys (Earlz)
|
|
|
|
6bbca99 LSSharedFileListItemResolve() was deprecated in Mac OS X 10.10, use LSSharedFileListItemCopyResolvedURL() instead (Cory Fields)
|
|
6715efb [Qt] Payment request expiration bug fix (re-done) (Philip Kaufmann)
|
