| Age | Commit message (Collapse) | Author |
|---|
|
Fixes #2724 and #1570.
Adds the
automatically-subtract-the-fee-from-the-amount-and-send-whats-left
feature to the GUI and RPC (sendtoaddress,sendmany).
|
|
|
|
deda3e1 [Qt] remove unused getNumBlocksAtStartup() from ClientModel (Philip Kaufmann)
47ee8cf [Qt] use qint64 in BitcoinGUI::setNumBlocks (Philip Kaufmann)
|
|
d23b0a2 depends: always use static qt5 for linux (Cory Fields)
3448b13 build: fix typo in configure help (Cory Fields)
c95ac83 gitian: fix x86_64 build with static libstdc++ (Cory Fields)
0671516 build: change reduce exports/static libstdc++ options for gitian and travis (Cory Fields)
aa36730 build: remove libstdc++ backwards-compat (Cory Fields)
3ee028f build: disable reduced exports by default (Cory Fields)
|
|
16a58a8 keys: remove libsecp256k1 verification until it's actually supported (Cory Fields)
|
|
This was added a while ago for testing purposes, but was never intended to be
used. Remove it until upstream libsecp256k1 decides that verification is
stable/ready.
|
|
9abbeea Remove obsolete pubsub method definitions (Pieter Wuille)
|
|
25cf6f3 minor rework of SendMoney in rpcwallet (Philip Kaufmann)
|
|
85da07a Better fingerprinting protection for non-main-chain getdatas. (Pieter Wuille)
|
|
|
|
de5403f [GUI] Move fee dialog minimise button away from "Transaction Fee" (Michael Ford)
|
|
Code to avoid calling Perfmon too often is only needed when perfmon is actually going to get called.
This is not intended to make any functional difference in the addition of entropy to the random pool.
|
|
With headers-first we can compare against the best header timestamp, rather
than using checkpoints which require code updates to maintain.
|
|
Backwards-compatibility for libstdc++ is not limited to straightforward abi
changes. Symbol visibility also needs to be taken into consideration, and
that really can't be addressed simply.
Instead, just static-link libstdc++ for backwards-compat.
|
|
Its original placement was causing confusion among some users.
|
|
e5d9d77 fix crash: createmultisig and addmultisigaddress (fsb4000)
|
|
1630219 openssl: abstract out OPENSSL_cleanse (Cory Fields)
|
|
850c570 No longer check osx compatibility in RenameThread (Michael Ford)
|
|
e5ece05 Rename Interval() to DifficultyAdjustmentInterval() (Shaul Kfir)
|
|
78c6bed Add test for DER-encoding edge case (Suhas Daftuar)
6f50dbd Fix NegateSignatureS to not duplicate last byte of S (Suhas Daftuar)
|
|
|
|
f5791c6 Add more information to errors in ReadBlockFromDisk (Wladimir J. van der Laan)
|
|
This makes it easier for us to replace it if desired, since it's now only in
one spot. Also, it avoids the openssl include from allocators.h, which
essentially forced openssl to be included from every compilation unit.
|
|
The fix to NegateSignatureS caused a test which had been failing
in IsValidSignatureEncoding to then fail in IsLowDERSignature.
Add new test so the original check remains exercised.
|
|
NegateSignatureS is called with a signature without a hashtype, so
do not save the last byte and append it after S negation.
Updates the two tests which were affected by this bug.
|
|
2c0f901 [REST] rest/chaininfos add documentation (Jonas Schnelli)
59582c8 [REST] add /rest/chaininfos (Jonas Schnelli)
|
|
a651668 [Qt] prevent amount overflow problem with payment requests (Philip Kaufmann)
|
|
eb1c2cd Split logic to undo txin's off DisconnectBlock. (Daniel Kraft)
|
|
28ee7e8 Get rid of DetectShutdownThread (Wladimir J. van der Laan)
|
|
f4b2078 Replace difficulty readjustment blocks with Interval() (Shaul Kfir)
|
|
d67a642 [Qt] add bitcoin logo to about screen (Jonas Schnelli)
|
|
|
|
- as QDateTime.secsTo() returns a qint64 also store in a qint64 and not in
an integer
|
|
Normally bitcoin core does not display any network originated strings without
sanitizing or hex encoding. This wasn't done for strcommand in many places.
This could be used to play havoc with a terminal displaying the logs,
especially with printtoconsole in use.
Thanks to Evil-Knievel for reporting this issue.
|
|
cf008ac Acquire CCheckQueue's lock to avoid race condition (Suhas Daftuar)
|
|
A lot of times, disk corruption problems appear here.
To facilitate debugging and troubleshooting, add position information
to the error messages.
|
|
|
|
getblocktemplate didn't have a wallet lock before #5711 and IMO there is no need for LEAVE/ENTER critical section.
|
|
- rework the function to not log errors but use throw JSONRPCError
- remove a check for IsLocked() that is done in sendtoaddress and
sendfrom RPC calls already
- cache GetBalance() return value, because it's possibly used twice
|
|
35f7227 Clean up wallet encryption code. (Daniel Kraft)
|
|
Bitcoin amounts are stored as uint64 in the protobuf messages (see
paymentrequest.proto), but CAmount is defined as int64_t. Because
of that we need to verify that single and accumulated amounts are
in a valid range and no variable overflow has happened.
- fixes #5624 (#5622)
Thanks @SergioDemianLerner for reporting that issue and also supplying us
with a possible solution.
- add static verifyAmount() function to PaymentServer and move the logging
on error into the function
- also add a unit test to paymentservertests.cpp
|
|
7f991e3 c++11: These look like user-defined literals. (Cory Fields)
5a6155c c++11: don't forward-declare types used in maps (Cory Fields)
3447cf8 c++11: MOVEONLY: break circular dependency in wallet (Cory Fields)
bbacd88 c++11: MOVEONLY: move function definitions out of the header (Cory Fields)
a2b04dd build: fix newer boost build with c++11 (Cory Fields)
|
|
5ebe095 Trim RPC command table (Wladimir J. van der Laan)
4401b2d Removed main.h dependency from rpcserver.cpp (Eric Lombrozo)
|
|
Add a space to keep the compiler happy
|
|
|
|
c++11 (libc++'s stdlib implementation anyway) doesn't allow for map types to be
forward-declared. for example:
class foo;
std::map<int, foo> bar; // error, foo has not been defined.
class foo{};
Since CWallet and CWalletTx are inter-dependent, but only std::map<*,CWalletTx>
is used, forward-declare CWallet instead and define CWalletTx first.
Despite the mangled git diff, this change only amounts to moving ~320 lines in
a single chunk.
|
|
These need to be moved out of the header in order to resolve a circular
dependency between CWallet and CTxWallet. See next commit.
|
|
|
|
Instead, create a separate function that applies the undo operation of a
CTxInUndo object onto a CCoinsViewCache. This method is used from
DisconnectBlock.
|
|
This fixes a potential race condition in the CCheckQueueControl constructor,
which was looking directly at data in CCheckQueue without acquiring its lock.
Remove the now-unnecessary friendship for CCheckQueueControl
|
