aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2015-06-06Get rid of fPlus argument to FormatMoneyWladimir J. van der Laan
It's never used with any other value than false, the default.
2015-06-06Don't go through double in AmountFromValue and ValueFromAmountWladimir J. van der Laan
My prime gripe with JSON spirit was that monetary values still had to be converted from and to floating point which can cause deviations (see #3759 and https://bitcoin.stackexchange.com/questions/22716/bitcoind-sendfrom-round-amount-error). As UniValue stores internal values as strings, this is no longer necessary. This avoids risky double-to-integer and integer-to-double conversions completely, and results in more elegant code to boot.
2015-06-05Merge pull request #6152Wladimir J. van der Laan
08d9373 Remove unused code from wallet and validation interface (Michael Ford)
2015-06-05Merge pull request #6206Wladimir J. van der Laan
a9ac95c use const references where appropriate (Philip Kaufmann)
2015-06-04fix rpcmining/getblocktemplate univalue transition logic errorJonas Schnelli
2015-06-04use const references where appropriatePhilip Kaufmann
2015-06-04univalue: add type check unit testsJonas Schnelli
2015-06-04univalue: add strict type checkingWladimir J. van der Laan
2015-06-04util: Add ParseInt64 and ParseDouble functionsWladimir J. van der Laan
Strict parsing functions for other numeric types. - ParseInt64 analogous to ParseInt32, but for 64-bit values. - ParseDouble for doubles. - Make all three Parse* functions more strict (e.g. reject whitespace on the inside) Also add tests.
2015-06-04Simplify RPCclient, adapt json_parse_error testWladimir J. van der Laan
# Conflicts: # src/test/rpc_tests.cpp
2015-06-04fix univalue json parse testsJonas Schnelli
2015-06-04fix missing univalue types during constructingJonas Schnelli
2015-06-04fix rpc batching univalue issueJonas Schnelli
2015-06-04Remove JSON Spirit wrapper, remove JSON Spirit leftoversJonas Schnelli
- implement find_value() function for UniValue - replace all Array/Value/Object types with UniValues, remove JSON Spirit to UniValue wrapper - remove JSON Spirit sources
2015-06-04remove JSON Spirit UniValue wrapperJonas Schnelli
2015-06-04fix rpc unit test, plain numbers are not JSON compatible objectJonas Schnelli
UniValues read() does only read valid json.
2015-06-04univalue: correct bool supportJonas Schnelli
2015-06-04univalue: add support for real, fix percision and make it json_spirit compatibleJonas Schnelli
- avoid breaking the API because of different number/percision handling
2015-06-04special threatment for null,true,false because they are non valid jsonJonas Schnelli
2015-06-04expicit set UniValue type to avoid empty valuesJonas Schnelli
2015-06-04extend conversion to UniValueJonas Schnelli
2015-06-04Convert tree to using univalue. Eliminate all json_spirit uses.Jeff Garzik
2015-06-04UniValue: export NullUniValue global constantJeff Garzik
2015-06-04UniValue: prefer .size() to .count(), to harmonize w/ existing treeJeff Garzik
2015-06-03Merge pull request #6220Wladimir J. van der Laan
d648236 bump version in clientversion.h (Philip Kaufmann)
2015-06-03Merge pull request #5875Wladimir J. van der Laan
aa8c827 P2P regression test for new AcceptBlock behavior (Suhas Daftuar) 9be0e68 Be stricter in processing unrequested blocks (Suhas Daftuar)
2015-06-03json: fail read_string if string contains trailing garbageWladimir J. van der Laan
Change `read_string` to fail when not the entire input has been consumed. This avoids unexpected, even dangerous behavior (fixes #6223). The new JSON parser adapted in #6121 also solves this problem so in master this is a temporary fix, but should be backported to older releases. Also adds tests for the new behavior.
2015-06-02Be stricter in processing unrequested blocksSuhas Daftuar
AcceptBlock will no longer process an unrequested block, unless it has not been previously processed and has more work than chainActive.Tip()
2015-06-02bump version in clientversion.hPhilip Kaufmann
2015-06-02Merge pull request #6203Wladimir J. van der Laan
d449772 Remove P2SH coinbase flag, no longer interesting (Luke Dashjr)
2015-06-02Merge pull request #6172Wladimir J. van der Laan
a1ba077 Ignore getheaders requests when not synced. (Suhas Daftuar)
2015-06-01Merge pull request #6183Wladimir J. van der Laan
28bf062 Fix off-by-one error w/ nLockTime in the wallet (Peter Todd)
2015-06-01Merge pull request #6164Wladimir J. van der Laan
aa41bc8 Update help message to match the #4219 change (lpescher) f60bb5e Update documentation to match the #4219 change (lpescher) cb87386 Make command line option to show all debugging consistent with similar options (lpescher)
2015-06-01Merge pull request #6198Wladimir J. van der Laan
0bb4385 Improve comment explaining purpose of MAX_MONEY constant (Peter Todd)
2015-06-01Merge pull request #6208Wladimir J. van der Laan
d6922aa [net, trivial] remove using namespace std pollution in netbase.cpp (Philip Kaufmann) 49b2292 [net, trivial] explicitly use std::string for FindNode (Philip Kaufmann)
2015-06-01Merge pull request #6193Wladimir J. van der Laan
6e71efa [REST] remove json input for getutxos, limit to query max. 15 outpoints (Jonas Schnelli) 64b8027 rest.cpp: strip whitespace (Jonas Schnelli)
2015-06-01Merge pull request #6195Wladimir J. van der Laan
8273793 Eliminate compiler warning due to unused variable (Suhas Daftuar)
2015-05-31[net, trivial] remove using namespace std pollution in netbase.cppPhilip Kaufmann
2015-05-31[net, trivial] explicitly use std::string for FindNodePhilip Kaufmann
- in OpenNetworkConnection we have a FindNode call, which gets a const char*, wheras we only have defined a FindNode for std::string
2015-05-31Remove P2SH coinbase flag, no longer interestingLuke Dashjr
2015-05-27Improve comment explaining purpose of MAX_MONEY constantPeter Todd
2015-05-27[REST] remove json input for getutxos, limit to query max. 15 outpointsJonas Schnelli
Remove possibility to send json encoded parameters to `/rest/getutxos/` to avoid possible DoS scenarios. The JSON output option is untouched.
2015-05-27Eliminate compiler warning due to unused variableSuhas Daftuar
2015-05-27Ignore getheaders requests when not synced.Suhas Daftuar
2015-05-27Chainparams: Explicit CMessageHeader::MessageStartChars to functions in main:Jorge Timón
-UndoWriteToDisk -WriteBlockToDisk
2015-05-27Merge pull request #5669Wladimir J. van der Laan
da29ecb Consensus: MOVEONLY: Move CValidationState from main consensus/validation (jtimon) 27afcd8 Consensus: Refactor: Decouple CValidationState from main::AbortNode() (Cory Fields)
2015-05-27Fix off-by-one error w/ nLockTime in the walletPeter Todd
Previously due to an off-by-one error the wallet ignored nLockTime-by-height transactions that would be valid in the next block even though they are accepted into the mempool. The transactions wouldn't show up until confirmed, nor would they be included in the unconfirmed balance. Similar to the mempool behavior fix in 665bdd3b, the wallet code was calling IsFinalTx() directly without taking into account the fact that doing so tells you if the transaction could have been mined in the *current* block, rather than the next block. To fix this we strip IsFinalTx() of non-consensus-critical functionality, removing the default arguments, and add CheckFinalTx() to check if a transaction will be final in the next block.
2015-05-27rest.cpp: strip whitespaceJonas Schnelli
2015-05-27Merge pull request #6153Wladimir J. van der Laan
8c35b6f Parameter interaction: disable upnp if -proxy set (Wladimir J. van der Laan)
2015-05-27Merge pull request #6186Wladimir J. van der Laan
b45c50c Fix two problems in CSubNet parsing (Wladimir J. van der Laan) 19e8d7b Simplify code for CSubnet (Wladimir J. van der Laan)