| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Report transaction conflicts, and tentative account balance fix
|
|
Adds a "walletconflicts" array to transaction info; if
a wallet transaction is mutated, the alternate transaction id
or ids are reported there (usually the array will be empty).
Metadata from the original transaction is copied to the mutant,
so the transaction time and "from" account of the mutant are
reported correctly.
|
|
Handle "conflicted" transactions properly
|
|
- Exclamation mark icon for conflicted transactions
- Show mouseover status for conflicted transactions as "conflicted"
- Don't show inactive transactions on overview page overview
|
|
This diagnostic tool removes all "tx" records from the wallet db,
then forces a full rescan, to rebuild "tx" records accurately.
|
|
Extend CMerkleTx::GetDepthInMainChain with the concept of
a "conflicted" transaction-- a transaction generated by the wallet
that is not in the main chain or in the mempool, and, therefore,
will likely never be confirmed.
GetDepthInMainChain() now returns -1 for conflicted transactions
(0 for unconfirmed-but-in-the-mempool, and >1 for confirmed).
This makes getbalance, getbalance '*', and listunspent all agree when there are
mutated transactions in the wallet.
Before:
listunspent: one 49BTC output
getbalance: 96 BTC (change counted twice)
getbalance '*': 46 BTC (spends counted twice)
After: all agree, 49 BTC available to spend.
|
|
0542619 Rename IsConfirmed to IsTrusted to better match the intended behavior. (Gregory Maxwell)
|
|
This allows getting raw transaction data from the wallet even if the
transaction is no longer in the blockchain / mempool (for example if it
got orphaned due to malleability abuse).
|
|
This doesn't change the functionality at all.
|
|
This commit strengthens 1bbca249b202c4802cc2c4d4de4a26e6392b4d92 by updating the CWalletTx::IsConfirmed() function.
If (bSpendZeroConfChange==false), then IsConfirmed() should actually treat unconfirmed change as being unconfirmed.
|
|
1bbca24 Add option to avoid spending unconfirmed change (Wladimir J. van der Laan)
|
|
|
|
|
|
|
|
cdb6c16 remove setting methods in wallet/walletdb (Cozz Lovan)
44eb59e [Qt] remove broken OptionsModel::Upgrade() (Cozz Lovan)
|
|
6943cb9 small changes to rpc command help message strings (Philip Kaufmann)
|
|
Limit the number of orphan blocks in memory
|
|
|
|
|
|
|
|
In case the total number of orphan blocks in memory exceeds a limit
(currently set to 750), a random orphan block (which is not
depended on by another orphan block) is dropped. This means it will
need to be downloaded again, but it won't consume memory until then.
|
|
c117d9e Support for error messages and a few more rejection reasons (Luke Dashjr)
14e7ffc Use standard BIP 22 rejection reasons where applicable (Luke Dashjr)
|
|
|
|
c32a486 Add more data-driven tests. (Matt Corallo)
|
|
Just for completeness. Only a few messages changed or moved since last time.
Don't change any translatable messages until 0.9 final unless really necessary.
|
|
|
|
df966d1 log parameter interactions to debug.log (Philip Kaufmann)
|
|
Prepare block connection logic for headers-first
|
|
|
|
|
|
Commit a22eed6a got reverted in a RPC documentation update, redo it.
|
|
`bitcoin-qt --help` was missing a final newline.
|
|
|
|
.rc's should be linked into the executable directly,
not through a helper library.
|
|
|
|
The getaddednodeinfo RPC call, when invoked with the dns flag set to
false, returns a malformed JSON object with duplicate keys.
Change this to return an array of objects with one key as
shown in the help message.
Fixes #3581.
|
|
|
|
|
|
3cf1f43 Mention `*` value for account in documentation for `getbalance` RPC (Wladimir J. van der Laan)
|
|
- remove btc address length from address validator
- add an optional btc address check in validated line edit that defaults
to off and is used in GUIUtil::setupAddressWidget()
- an isAcceptable() check is added to validated line edit on focus out
which only kicks in, when a validator is used with that widget
- remove an isAcceptable() check from sendcoinsentry.cpp
- remove obsolete attributes from ui files, which are set by calling
GUIUtil::setupAddressWidget()
- move some more things to GUIUtil::setupAddressWidget() and remove them
from normal code e.g. placeholder text
|
|
|
|
4c0b2cd Win32: use a more modern API call in FileCommit() (Philip Kaufmann)
|
|
As reported by @Subo1978, error messages don't have a trailing newline
anymore after commit b77dfdc9. Add back this newline.
|
|
e5aadb2 Updated fallback seed nodes from sipa's DNS seeds (Gavin Andresen)
|
|
c7f9332 Add check for valid keys in `importprivkey` (Wladimir J. van der Laan)
|
|
edd735d [Qt] Fix coin control labels update (Cozz Lovan)
|
|
d7aa1ec [Qt] fix bitcoin: URI strings (spelling fixes) (Philip Kaufmann)
|
|
|
|
The base58 armoring was checked, but not the resulting private key,
which could be out of range. Fix this by adding a check.
|
