| Age | Commit message (Collapse) | Author |
|---|
|
A few new messages have been added since last update.
|
|
Document that CPubKey.IsValid() is consensus critical
|
|
Make tinyformat errors raise an exception instead of assert()ing
|
|
Remove CWalletTx::vfSpent
|
|
These days we regard transactions with one confirmation to be
'Confirmed'.
Waiting for 6 confirmations is a recommendation but should not
keep the transaction shown as unconfirmed.
Misc code sanity:
- Merge maturity/status enums, they had become completely disjunct
- 'confirmed' flag is now called 'countsForBalance' for clarity
|
|
By default tinyformat errors such as 'wrong number of conversion
specifiers in format string' cause an assertion failure.
Raise an exception instead so that error handling can recover or can
show an appropriate error.
|
|
|
|
5d5b0d2 Add shell null to else block (Wil Bown)
|
|
4423571 Replace PrintException with PrintExceptionContinue + throw (Wladimir J. van der Laan)
|
|
MinGW-W64-builds-4.2.0 shell doesn't like the empty else blocks.
|
|
script: reduce OP_RETURN standard relay bytes to 40
|
|
Per mailing list discussion.
|
|
Remove PRIx64 usage completely
|
|
Use the spent outpoint multimap to figure out which wallet transaction
outputs are unspent, instead of a vfSpent array that is saved
to disk.
|
|
Just a pet peeve.
(PrintException has exactly the same body as PrintExceptionContinue but
does a re-throw at the end. Move these re-throws to the call
site, this aids understanding what is going on as well as eliminates a
bit of code duplication in util.cpp)
|
|
|
|
e6c6bc9 Adds additional zero checks for setCompact These encoded values should all decode to zero (Noel Tiernan)
|
|
a3138ed add test of DecodeBase58 skipping whitespace (Christian von Roques)
|
|
|
|
Wallet locking fixes for -DDEBUG_LOCKORDER
|
|
Drop fees by 10x due to the persistently higher exchange rate.
|
|
script: tighten multisig non-standard rules: do not relay pubkeys above 65 bytes
|
|
This was a bad idea. This can't be solved with macros as any
other library that includes inttypes.h will get in the way.
The parent commit has removed all usages from the source, this commit
removes the definition.
|
|
Amend to d5f1e72. It turns out that BerkelyDB was including inttypes.h
indirectly, so we cannot fix this with just macros.
Trivial commit: apply the following script to all .cpp and .h files:
# Middle
sed -i 's/"PRIx64"/x/g' "$1"
sed -i 's/"PRIu64"/u/g' "$1"
sed -i 's/"PRId64"/d/g' "$1"
# Initial
sed -i 's/PRIx64"/"x/g' "$1"
sed -i 's/PRIu64"/"u/g' "$1"
sed -i 's/PRId64"/"d/g' "$1"
# Trailing
sed -i 's/"PRIx64/x"/g' "$1"
sed -i 's/"PRIu64/u"/g' "$1"
sed -i 's/"PRId64/d"/g' "$1"
After this commit, `git grep` for PRI.64 should turn up nothing except
the defines in util.h.
|
|
d5f1e72 Don't use PRIx64 formatting derives from inttypes.h (Wladimir J. van der Laan)
|
|
|
|
As the tinyformat-based formatting system (introduced in b77dfdc) is
type-safe, no special format characters are needed to specify sizes.
Tinyformat can support (ignore) the C99 prefixes such as "ll" but
chokes on MSVC's inttypes.h defines prefixes such as "I64X". So don't
include inttypes.h and define our own for compatibility.
(an alternative would be to sweep the entire codebase using sed -i to
get rid of the size specifiers but this has less diff impact)
|
|
We were losing information about sent/received by overriding the
category in case of a conflicted transaction.
Hence, remove the "conflicted" category.
Conflicted status of a transaction can still be determined by looking
for confirmations<0.
|
|
|
|
|
|
d8b4b49 Don't store or send side-chain blocks lower than last checkpoint. (Ashley Holman)
|
|
ad54a9b Change new constants in txdb.h to int64_t (Wladimir J. van der Laan)
|
|
ddcabae qt: Rename 'Confirmed' balance to 'Spendable' on overview page (Wladimir J. van der Laan)
|
|
The word 'Spendable' more precisely says what the balance actually means.
Avoids the confirmed/unconfirmed confusion that can be caused by #3676.
|
|
Compiling with -DDEBUG_LOCKORDER and running the qa/rpc-test/ regression
tests uncovered a couple of wallet methods that should (but didn't)
acquire the cs_wallet mutext.
I also changed the AssertLockHeld() routine print to stderr and
abort, instead of printing to debug.log and then assert()'ing.
It is annoying to look in debug.log to find out which
AssertLockHeld is failing.
|
|
A shift overflow was happening when using these to check against in init.cpp.
Fixes #3702.
|
|
f05fa03 [Qt] small .ui cleanup for optionsdialog and coincontrol (Philip Kaufmann)
|
|
82e9600 add constants for shared (GUI/core) -dbcache settings (Philip Kaufmann)
879b390 Increase default dbcache to 100 MiB (Pieter Wuille)
|
|
a143d4c Fix crash in importwallet and dumpwallet formatting (Wladimir J. van der Laan)
|
|
- DecodeDumpTime was passing a statically allocated facet object to
std::locale. However, "The constructed locale object takes over
responsibility for deleting this facet object." causing a free()
crash on scope exit. Fixes #3670.
- EncodeDumpTime was using the wrong format character for dates
(appears accidentally introduced in 51ed9ec9)
|
|
Document new `walletpassphrase` behavior in 0.9
|
|
Serialize only CTransaction data in gettransaction RPC hex
|
|
|
|
- adds nDefaultDbCache, nMaxDbCache and nMinDbCache in txdb.h
|
|
|
|
ceb8e22 [Qt] allow translation of client bitness (Philip Kaufmann)
|
|
bbfce8a fix non-standard reason string in main.cpp (Philip Kaufmann)
|
|
b920148 [Qt] Improve single step in bitcoinamountfield (Cozz Lovan)
|
|
d54e819 Log warnings when bootstrap files are specified but cannot be opened (Wladimir J. van der Laan)
|
|
Don't include trailing implementation-specific wallet metadata.
Fixes 3a1c20b.
|
