aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2013-12-10Use thread-local storage for LogPrint(category...)Gavin Andresen
This prevents crashes at shutdown where a global destructor calls LogPrint(category...) after mapMultiArgs has been deleted.
2013-12-10Fix infinite loop with LogPrint on WindowsGavin Andresen
Running -printtodebugger -debug (or -debug=lock), compiled with -DDEBUG_LOCKORDER would infinite loop on Windows because every critical section lock/unlock triggers a LogPrint. Solution is to use the raw boost mutex instead of a CCriticalSection.
2013-12-09Merge pull request #3207Wladimir J. van der Laan
666893b qt: keep a list of requested payments (Wladimir J. van der Laan)
2013-12-09rpcwallet: use EnsureWalletIsUnlocked() where possiblePhilip Kaufmann
- replaces a pwalletMain->IsLocked() check - in keypoolrefill init kpSize to 0 as we have the logic to determine max kpSize in pwalletMain->TopUpKeyPool() anyway
2013-12-09Merge pull request #3297Wladimir J. van der Laan
84f8551 [Qt] misc small Mac related changes/cleanups (Philip Kaufmann)
2013-12-09[Qt] misc small Mac related changes/cleanupsPhilip Kaufmann
- cleanup Info.plist.in and specify high DPI mode enable command as per http://blog.qt.digia.com/blog/2013/04/25/retina-display-support-for-mac-os-ios-and-x11/ - move setting of QApplication::setAttribute() to bitcoin.cpp and add attribute for enabling use of high DPI pixmaps for Qt >= 5.1 - add missing setWindowTitle() on Mac - cleanup Mac / non-Mac setup in bitcoingui.cpp
2013-12-09Merge pull request #3373Wladimir J. van der Laan
80ecf67 Add ThreadGetMyExternalIP to net thread group (Gavin Andresen)
2013-12-09Add ThreadGetMyExternalIP to net thread groupGavin Andresen
Fixes #3372 -- crash at shutdown.
2013-12-08Add main-specific node statePieter Wuille
2013-12-08Merge pull request #3348Wladimir J. van der Laan
ccd1372 [Qt] small notificator and style changes (Philip Kaufmann)
2013-12-08Merge pull request #3322Wladimir J. van der Laan
26d1b65 src/Makefile.am: Simplify clean of leveldb (Josh Triplett) a26a367 configure.ac: Check for miniupnpc headers, not just -lminiupnpc (Josh Triplett) 82ccb05 autogen.sh: Stop passing --verbose to autoreconf (Josh Triplett) e12dafd autogen.sh: Use long options to autoreconf, for self-documentation (Josh Triplett) 19b9add autogen.sh: Support running from outside the source directory (Josh Triplett) 97d285a autogen.sh: Use set -e to fail if any command fails (Josh Triplett) f80b723 autogen.sh: Add a /bin/sh shebang. (Josh Triplett)
2013-12-08Merge pull request #3332Wladimir J. van der Laan
5094f8d Split off rpc_wallet_tests (Wladimir J. van der Laan) 829c920 Move CCryptoKeyStore to crypter.cpp (Wladimir J. van der Laan) ae6ea5a Update build-unix.md to mention --disable-wallet (Wladimir J. van der Laan) 4f9e993 Add --disable-wallet option to build system (Wladimir J. van der Laan) d004d72 Move CAddrDB frrom db to net (Wladimir J. van der Laan) 48ba56c Delimit code with #ifdef ENABLE_WALLET (Wladimir J. van der Laan) 991685d Move getinfo to rpcnet.cpp (Wladimir J. van der Laan) bbb0936 Move HelpExample* from rpcwallet to rpcserver (Wladimir J. van der Laan)
2013-12-06Merge pull request #3365 from gmaxwell/hexifyGavin Andresen
Restore hex to getrawtransaction vout scriptPubkey.
2013-12-06Restore hex to getrawtransaction vout scriptPubkey.Gregory Maxwell
Commit be066fad accidentally removed the hex field. This gets in the way of doing offline signing. (credit belongs to sipa for actually looking for the cause instead of being lazy like me and just shrugging and writing the scriptpubkey from the asm.)
2013-12-06[Qt] misc PaymentServer changes (e.g. changes to eventFilter())Philip Kaufmann
- make eventFilter() private and pass events on to QObject::eventFilter() instead of just returning false - re-work paymentservertest.cpp to correctly handle the event test after the above change (rewrite test_main to allow usage of QCoreApplication:: in the tests) - delete socket when we were unable to connect in ipcSendCommandLine() - show a message to the user if we fail to start-up (instead of just a debug.log entry) - misc small comment changes
2013-12-06Merge pull request #3353Wladimir J. van der Laan
1e01f7c Payment request URI syntax changed, from request=... to r=... (Gavin Andresen)
2013-12-05fix typo in rpcnet.cppPhilip Kaufmann
2013-12-05Merge pull request #3356Wladimir J. van der Laan
d3ef9b0 Prevent empty transactions from being added to vtxPrev (Wladimir J. van der Laan)
2013-12-04Refuse to retransmit transactions without vinsWladimir J. van der Laan
Versions of bitcoin before 0.8.6 have a bug that inserted empty transactions into the vtxPrev in the wallet, which will cause the node to be banned when retransmitted, hence add a check for !tx.vin.empty() before RelayTransaction.
2013-12-04Prevent empty transactions from being added to vtxPrevWladimir J. van der Laan
CWalletTx::AddSupportingTransactions() was adding empty transaction to vtxPrev in some cases. Skip over these. Part one of the solution to #3190. This prevents invalid vtxPrev from entering the wallet, but not current ones being transmitted.
2013-12-04Split off rpc_wallet_testsWladimir J. van der Laan
Split wallet tests from other RPC tests. Now no #ifdef ENABLE_WALLET are needed anymore in either file.
2013-12-04Move CCryptoKeyStore to crypter.cppWladimir J. van der Laan
This breaks the dependency on crypter for disable-wallet builds.
2013-12-04Add --disable-wallet option to build systemWladimir J. van der Laan
Make it possible to build Bitcoin without wallet (and thus without BDB) so that it only functions as node.
2013-12-04Move CAddrDB frrom db to netWladimir J. van der Laan
This was a leftover from the times in which peers.dat depended in BDB. Other functions in db.cpp still depend on BerkelyDB, to be able to compile without BDB this (small) functionality needs to be moved to another file.
2013-12-04Delimit code with #ifdef ENABLE_WALLETWladimir J. van der Laan
Delimit all code that uses the wallet functions in implementation files that conditionally use the wallet.
2013-12-04Move getinfo to rpcnet.cppWladimir J. van der Laan
Where to place `getinfo` is a difficult issue as it shows information from the wallet, net and block chain. However, I moved it out of rpcwallet as the command needs also to be available without wallet.
2013-12-04Move HelpExample* from rpcwallet to rpcserverWladimir J. van der Laan
General functions used throughout the RPC framework don't belong in rpcwallet.
2013-12-04qt: use deleteLater to remove send entriesWladimir J. van der Laan
Use deleteLater() instead of delete, as it is not allowed to delete widgets directly in an event handler. Should solve the MacOSX random crashes on send with coincontrol.
2013-12-04Payment request URI syntax changed, from request=... to r=...Gavin Andresen
BIP 72 was changed to save six bytes in bitcoin: URIs.
2013-12-03Merge pull request #3285Wladimir J. van der Laan
d3207b6 [Qt] coin-control features GUI cleanup 3 (Philip Kaufmann) 834e14e [Qt] coin-control features GUI cleanup 2 (Philip Kaufmann)
2013-12-03[Qt] small notificator and style changesPhilip Kaufmann
- remove default arguments for notificator - re-order some calls to use same ordering in Qt files - style police changes (spaces, comments and such)
2013-12-03Merge pull request #3320 from laanwj/2013_11_cli_splitGavin Andresen
bitcoin-cli: remove unneeded dependencies (only minor code movement)
2013-12-03bitcoin-cli: remove unneeded dependencies (only code movement)Wladimir J. van der Laan
Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server) Build system changes: - split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a Code changes (movement only): - split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp - move uiInterface from init.cpp to util.cpp
2013-12-02Sanitize assert usage and refuse to compile with NDEBUG.Gregory Maxwell
There were quite a few places where assert() was used with side effects, making operation with NDEBUG non-functional. This commit fixes all the cases I know about, but also adds an #error on NDEBUG because the code is untested without assertions and may still have vulnerabilities if used without assert.
2013-12-02[Qt] coin-control features GUI cleanup 3Philip Kaufmann
- remove style sheets from ui files and use Qt attributes instead - make some more strings untranslatable, to make life for translators easier - split up long tooltips an rework the texts a little
2013-12-02[Qt] coin-control features GUI cleanup 2Philip Kaufmann
- remove monospace labels from sendcoinsdialog also - use a validated line edit for the change address - add a tooltip to change address switch - ensure we have a valid change address in CoinControlDialog::coinControl->destChange or just CNoDestination() - some small ui file changes
2013-12-02Lossless image optimizationSined
less bytes, same images
2013-12-02Merge pull request #3339Wladimir J. van der Laan
bae6c7e Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. (Ryan Niebur)
2013-12-01Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that ↵Ryan Niebur
was not necessary, as the field still receives focus without it.
2013-12-02Make unit tests succeed with -DDEBUG_LOCKORDERGavin Andresen
2013-12-01Merge pull request #3329 from gavinandresen/syncdebugGavin Andresen
mutex debugging routines: LocksHeld() and AssertLockHeld()
2013-12-01Merge pull request #3306Wladimir J. van der Laan
84b695c [Qt] allow deletion of payment-requests in sendcoins (Philip Kaufmann)
2013-11-30Add verbose boolean to getrawmempoolGavin Andresen
Also changes mempool to store CTxMemPoolEntries to keep track of when they enter/exit the pool.
2013-11-30Refactor: move GetValueIn(tx) to tx.GetValueIn()Gavin Andresen
GetValueIn makes more sense as a CTransaction member.
2013-11-30Remove dead transaction replacement codeGavin Andresen
This dead code can be resurrected from git history if transaction replacement is ever implemented. Keeping dead code in the source is a bad idea, because it implies it was tested and worked at some point, which is not true.
2013-11-29Merge pull request #3309Wladimir J. van der Laan
9ac5a01 Move types.h include before ifaddres.h for u_int declaration (Robert Backhaus)
2013-11-29mutex debugging routines: LocksHeld() and AssertLockHeld()Gavin Andresen
2013-11-28bitcoin-cli: Add missing SelectParamsFromCommandLineWladimir J. van der Laan
The SelectParamsFromCommandLine call was missing in bitcoin-cli, which caused `-testnet` and `-regtest` to be ignored. Add this call just like in bitcoind.cpp.
2013-11-27src/Makefile.am: Simplify clean of leveldbJosh Triplett
2013-11-27prevent Windows redefinition warning cause by compat.hPhilip Kaufmann