aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2015-07-27Unit test doublespends in new blocksGavin Andresen
As suggested by Greg Maxwell-- unit test to make sure a block with a double-spend in it doesn't pass validation if half of the double-spend is already in the memory pool (so full-blown transaction validation is skipped) when the block is received.
2015-07-27Cache transaction validation successesPieter Wuille
2015-07-27Merge pull request #5697Wladimir J. van der Laan
60c8bac Includes: Cleanup around net main and wallet (Jorge Timón) 9dd793f TRIVIAL: Missing includes (Jorge Timón)
2015-07-27rpc: Accept strings in AmountFromValueWladimir J. van der Laan
Accept strings containing decimal values, in addition to bare values. Useful from JSON-RPC implementations where it's not possible to have direct control over the text of numbers (e.g. where numbers are always doubles), and it's still desired to send an exact value. This would allow users to post JSON content with numbers encoded like `{"value": "0.00000001"}` instead of `{"value": 0.00000001}` which some php/python encoders wrap into 1e-8, or worse.
2015-07-27Merge pull request #6468Wladimir J. van der Laan
6f8b6d3 don't try to decode invalid encoded ext keys (Jonas Schnelli) 8d2af54 extend bip32 tests to cover Base58c/CExtKey decode (Jonas Schnelli) 7cb1f9f fix and extend CBitcoinExtKeyBase template (Jonas Schnelli)
2015-07-27Merge pull request #6471Wladimir J. van der Laan
060b3d3 fixup: qt 5.5 snuck in another module that needs path hand-holding (Cory Fields) ecd6a89 depends: make more qt flags explicit (Cory Fields) ab67dd7 depends: bump to qt 5.5 (Cory Fields) 5189fe3 depends: split qt config options to separate lines (Jacob Welsh) fe997df build: fix building against qt5.4/5.5 (Cory Fields)
2015-07-25don't try to decode invalid encoded ext keysJonas Schnelli
2015-07-24Merge pull request #6456Wladimir J. van der Laan
ec249d4 util: use locale-independent parsing in ParseDouble (Wladimir J. van der Laan) 7650449 univalue: Avoid unnecessary roundtrip through double for numbers (Wladimir J. van der Laan) e061e27 rpc: Make ValueFromAmount always return 8 decimals (Wladimir J. van der Laan)
2015-07-23build: fix building against qt5.4/5.5Cory Fields
2015-07-23Includes: Cleanup around net main and walletJorge Timón
-Move from .h to .cpp: in main, net and wallet -Remove unnecessary #include "main.h" -Cleanup some wallet files includes
2015-07-23TRIVIAL: Missing includesJorge Timón
2015-07-23Merge pull request #6287Wladimir J. van der Laan
a794284 locking: add a quick example of GUARDED_BY (Cory Fields) 2b890dd locking: fix a few small issues uncovered by -Wthread-safety (Cory Fields) cd27bba locking: teach Clang's -Wthread-safety to cope with our scoped lock macros (Cory Fields)
2015-07-23Merge pull request #5515Wladimir J. van der Laan
0fcc4e1 Assert on probable deadlocks if the second lock isnt try_lock (Matt Corallo)
2015-07-23extend bip32 tests to cover Base58c/CExtKey decodeJonas Schnelli
2015-07-23fix and extend CBitcoinExtKeyBase templateJonas Schnelli
- fix Decode call (req. only one param) - add constructor for base58c->CExtKey
2015-07-22Assert on probable deadlocks if the second lock isnt try_lockMatt Corallo
2015-07-22Merge pull request #6149Wladimir J. van der Laan
27d7605 Buffer log messages and explicitly open logs (Adam Weiss)
2015-07-21Merge pull request #6381Wladimir J. van der Laan
c4973aa Chainparams: CTestNetParams and CRegTestParams extend directly from CChainParams (Jorge Timón) d3cf546 Chainparams: Introduce CreateGenesisBlock() static function (Jorge Timón)
2015-07-21Merge pull request #6400Wladimir J. van der Laan
1327897 Reformat help text of estimatefee and estimatepriority to match other help texts. (Pavel Janík)
2015-07-21Merge pull request #6444Wladimir J. van der Laan
0aad1f1 Exempt unspendable transaction outputs from dust checks (zathras-crypto)
2015-07-20Reformat help text of estimatefee and estimatepriority to match other help ↵Pavel Janík
texts.
2015-07-20Merge pull request #6408Wladimir J. van der Laan
dca6040 [Qt] remove std namespace polution from code (Philip Kaufmann)
2015-07-20Separate core memory usage computation in core_memusage.hPieter Wuille
2015-07-20Fix warning introduced by #6412Wladimir J. van der Laan
SOCKET are defined as unsigned integers, thus always >=0.
2015-07-20Merge pull request #6412Wladimir J. van der Laan
d422f9b Test whether created sockets are select()able (Pieter Wuille)
2015-07-20Merge pull request #6447Wladimir J. van der Laan
2cb8ee9 remove unused inv from ConnectTip() (Pavel Vasin)
2015-07-19Documenting pruned, pruneheight and softforks in getblockchaininfoSimon Males
2015-07-18Exempt unspendable transaction outputs from dust checkszathras-crypto
Since unspendable outputs can't be spent, there is no threshold at which it would be uneconomic to spend them. This primarily targets transaction outputs with `OP_RETURN`. --- Initially based on: commit 9cf0ae26350033d43d5dd3c95054c0d1b1641eda Author: zathras-crypto <zathrasc@gmail.com> Date: Wed Mar 25 02:04:02 2015 -0700 Changes: - cherry-picked on top of bitcoin:master - added RPC test for fundrawtransaction
2015-07-18util: use locale-independent parsing in ParseDoubleWladimir J. van der Laan
Use locale-indepent C++ based parsing instead of C's strtod, which checks for different input based on the user's locale. Fixes #6443.
2015-07-18univalue: Avoid unnecessary roundtrip through double for numbersWladimir J. van der Laan
JSON makes no distinction between numbers and reals, and our code doesn't need to do so either. This removes VREAL, as well as its specific post-processing in `UniValue::write`. Non-monetary amounts do not need to be forcibly formatted with 8 decimals, so the extra roundtrip was unnecessary (and potentially loses precision).
2015-07-18rpc: Make ValueFromAmount always return 8 decimalsWladimir J. van der Laan
This is the format that was always returned to JSON clients. The difference was not noticed before, because VREAL values are post-processed by univalue. By implementing the functionality directly it breaks the dependency of rpcserver on utilmoneystr. FormatMoney is now only used for debugging purposes. To test, port over the formatting tests from util_tests.cpp to rpc_tests.cpp.
2015-07-16[Qt] remove std namespace polution from codePhilip Kaufmann
2015-07-16remove unused inv from ConnectTip()Pavel Vasin
2015-07-15Merge pull request #6438Wladimir J. van der Laan
d4b1d5a openssl: avoid config file load/race (Cory Fields)
2015-07-15qt: update forgotten emit to Q_EMIT in macdockiconhandler.mmWladimir J. van der Laan
Leftover from #6433
2015-07-15qt: define QT_NO_KEYWORDSWladimir J. van der Laan
QT_NO_KEYWORDS prevents Qt from defining the `foreach`, `signals`, `slots` and `emit` macros. Avoid overlap between Qt macros and boost - for example #undef hackiness in #6421.
2015-07-14openssl: avoid config file load/raceCory Fields
2015-07-13rpc: Implement random-cookie based authenticationWladimir J. van der Laan
When no `-rpcpassword` is specified, use a special 'cookie' file for authentication. This file is generated with random content when the daemon starts, and deleted when it exits. Read access to this file controls who can access through RPC. By default this file is stored in the data directory but it be overriden with `-rpccookiefile`. This is similar to Tor CookieAuthentication: see https://www.torproject.org/docs/tor-manual.html.en Alternative to #6258. Like that pull, this allows running bitcoind without any manual configuration. However, daemons should ideally never write to their configuration files, so I prefer this solution.
2015-07-13Merge pull request #6398Wladimir J. van der Laan
85ee55b rpc: Remove chain-specific RequireRPCPassword (Wladimir J. van der Laan)
2015-07-12Chainparams: CTestNetParams and CRegTestParams extend directly from CChainParamsJorge Timón
...instead of CMainParams and CTestNetParams respectively Do the same for CBaseChainParams. The inheritance was only reducing readibility in this case
2015-07-12Chainparams: Introduce CreateGenesisBlock() static functionJorge Timón
2015-07-11Merge pull request #6410Wladimir J. van der Laan
5098c47 Implement accurate memory accounting for mempool (Pieter Wuille)
2015-07-10Test whether created sockets are select()ablePieter Wuille
2015-07-10Merge pull request #6370Wladimir J. van der Laan
6ebac07 Remove ChainParams::DefaultMinerThreads (Wladimir J. van der Laan)
2015-07-10Merge pull request #6379Wladimir J. van der Laan
9cc9152 rpc: Accept scientific notation for monetary amounts in JSON (Wladimir J. van der Laan)
2015-07-10Implement accurate memory accounting for mempoolPieter Wuille
2015-07-10rpc: Accept scientific notation for monetary amounts in JSONWladimir J. van der Laan
Add a function `ParseFixedPoint` that parses numbers according to the JSON number specification and returns a 64-bit integer. Then this in `AmountFromValue`, rather than `ParseMoney`. Also add lots of tests (thanks to @jonasschnelli for some of them). Fixes issue #6297.
2015-07-10Merge pull request #5486Wladimir J. van der Laan
c45c7ea [REST] add JSON support for /rest/headers/ (Jonas Schnelli)
2015-07-10Merge pull request #5288Wladimir J. van der Laan
e3cae52 Added -whiteconnections=<n> option (Josh Lehan)
2015-07-10rpc: Remove chain-specific RequireRPCPasswordWladimir J. van der Laan
I've never liked the chain-specific exception to having to set a password. It gives issues with #6388 which makes it valid to set no password in every case (as it enables random cookie authentication). This pull removes the flag, so that all chains are regarded the same. It also removes the username==password test, which doesn't provide any substantial extra security.