aboutsummaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2019-07-19qt: pre-rc1 translations updateWladimir J. van der Laan
Tree-SHA512: b97fd91b7ab1eb2297007a9821def31c065a2a33f12cf51fd5e5be5dff1e8afb4f5b001d220c3873d72ca5b06484ad2d1e2c8df5300770145de0dfebe56db303
2019-07-19net: Make poll in InterruptibleRecv only filter for POLLIN events.tecnovert
poll should block until there is data to be read or the timeout expires. Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor. Removing POLLOUT matches how select is used when USE_POLL isn't defined. Github-Pull: #16412 Rebased-From: a52818cc5633494992da7d1dc8fdb04b4a1b7c29 Tree-SHA512: eaf466630ba9d2a2a7443c9679c83c2cb13e779a5948f409cddb4c48cf32126ac68f3de48e394f9302e99858efa17cdb14650751a1b55c3b79e8a7507cab352d
2019-07-17fix: tor: Call event_base_loopbreak from the event's callbackJoão Barbosa
Github-Pull: #16405 Rebased-From: a981e749e6553487cd48eda28e590f769e81c85c
2019-07-09qt: Assert QMetaObject::invokeMethod resultJoão Barbosa
Github-Pull: #16348 Rebased-From: 64fee489448c62319e77941c30152084695b5a5d
2019-07-09gui: Fix missing qRegisterMetaType(WalletModel*)João Barbosa
Github-Pull: #16348 Rebased-From: f27bd96b5fdc2921d93c44bbf422bff0e979c4de
2019-07-05signrawtransactionwithkey: report error when missing ↵Anthony Towns
redeemScript/witnessScript param Github-Pull: #16250 Rebased-From: 01174596e69568c434198a86f54cb9ea6740e6c2
2019-07-04Merge #16035: 0.18.1: Backportsfanquake
bcb27d7b0 .python-version: Bump to 3.5.6 (MarcoFalke) af25a757e Add comments to Python ECDSA implementation (John Newbery) 715da91e9 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov) 2800b3d5c gui: Fix open wallet menu initialization order (João Barbosa) e78007fc1 Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow) d9fc969e7 Pure python EC (Pieter Wuille) 23ba460c1 test: Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke) 13b3bb564 test: Fixup creatmultisig documentation and whitespace (MarcoFalke) 79745d175 Replace remaining fprintf with tfm::format manually (MarcoFalke) beb09f09b scripted-diff: Replace fprintf with tfm::format (MarcoFalke) e29aa6e72 Exceptions should be caught by reference, not by value. (Kristaps Kaupe) f88959ba7 tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke) 0023c9789 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) 832eb4ff5 Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr) 966d8d084 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr) bb36ac82e rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) d24d0ec05 Add example 2nd arg to signrawtransactionwithkey (Chris Moore) 592016ba1 fixup: Fix prunning test (João Barbosa) c80a498ae Fix RPC/pruneblockchain returned prune height (Jonas Schnelli) b2398240f gui: Enable open wallet menu on setWalletController (João Barbosa) d1f261150 Add test for GCC bug 90348 (Pieter Wuille) d80c558e0 gui: Set progressDialog to nullptr (João Barbosa) 7ed1a6019 gui: Enable console line edit on setClientModel (João Barbosa) b55cbe82d qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 (shannon1916) b6c1f9478 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke) 86031083c Add test for superfluous witness record in deserialization (Gregory Sanders) 5a58ddb6d Fix missing input template by making minimal tx (Gregory Sanders) 206f5ee87 Disallow extended encoding for non-witness transactions (Pieter Wuille) 3dbc7def0 Show loaded wallets as disabled in open menu instead of nothing (MeshCollider) a635377b6 Install bitcoin-wallet manpage. (Daniel Kraft) eb85ee62b Doc: remove text about txes always relayed from -whitelist (David A. Harding) 890a92eba doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) 3460555f4 test: Add test for p2p_blocksonly (MarcoFalke) 8f215c7a2 test: Format predicate source as multiline on error (MarcoFalke) 9c1a607a0 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) 5935f0126 build with -fstack-reuse=none (MarcoFalke) Pull request description: Tree-SHA512: 5cd73a4319cb69c92b528239cf97c0ed5fcf2b9e8c7fe154e4679eeec95db433a0223d8dc574e4cdc96c1913cfdf160b10c42dcdbcb5bbc8fb743c07930ef9da
2019-06-24Set AA_EnableHighDpiScaling attribute earlyHennadii Stepanov
Qt docs: This attribute must be set before QGuiApplication is constructed. Github-Pull: #16254 Rebased-From: 099e4b9ad3d9967051d5c3d45c6315d1b30fea05
2019-06-23gui: Fix open wallet menu initialization orderJoão Barbosa
The menu must be created before connecting to aboutToShow signal. Github-Pull: #16231 Rebased-From: 5224be5a3354e1a22ea4d7f0e40aadfccdf67064
2019-06-21Make and get the multisig redeemscript and destination in one function ↵Andrew Chow
instead of two Instead of creating a redeemScript with CreateMultisigRedeemscript and then getting the destination with AddAndGetDestinationForScript, do both in the same function. CreateMultisigRedeemscript is changed to AddAndGetMultisigDestination. It creates the redeemScript and returns it via an output parameter. Then it calls AddAndGetDestinationForScript to add the destination to the keystore and get the proper destination. This allows us to inspect the public keys in the redeemScript before creating the destination so that the correct destination is used when uncompressed pubkeys are in the multisig. Github-Pull: #16026 Rebased-From: a49503402b6bc21e3878e151c07529941d36aed0
2019-06-18Replace remaining fprintf with tfm::format manuallyMarcoFalke
Github-Pull: #16205 Rebased-From: fa8f195195945ce6258199af0461e3fbfbc1236d
2019-06-18scripted-diff: Replace fprintf with tfm::formatMarcoFalke
-BEGIN VERIFY SCRIPT- sed -i --regexp-extended -e 's/fprintf\(std(err|out), /tfm::format(std::c\1, /g' $(git grep -l 'fprintf(' -- ':(exclude)src/crypto' ':(exclude)src/leveldb' ':(exclude)src/univalue' ':(exclude)src/secp256k1') -END VERIFY SCRIPT- fixup! scripted-diff: Replace fprintf with tfm::format Github-Pull: #16205 Rebased-From: fac03ec43a15ad547161e37e53ea82482cc508f9
2019-06-18Exceptions should be caught by reference, not by value.Kristaps Kaupe
Github-Pull: #16095 Rebased-From: ae7faf20d5fb3e2415ccadc37100dfc44aa0cd94
2019-06-18tinyformat: Add doc to Bitcoin Core specific strprintfMarcoFalke
Github-Pull: #16205 Rebased-From: fa72a64b90dc07a80b1ca6127eb50d8244dedc3b
2019-06-18rpc: bugfix: Properly use iswitness in converttopsbtMarcoFalke
Also explain the param in all RPCs Github-Pull: #15899 Rebased-From: fa499b5f027f77c0bf13699852c8c06f78e27bef
2019-06-18rpc: Switch touched RPCs to IsValidNumArgsMarcoFalke
Github-Pull: #15899 Rebased-From: fa5c5cd141f0265a5693234690ac757b811157d8
2019-06-17Add example 2nd arg to signrawtransactionwithkeyChris Moore
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: #16210 Rebased-From: 71fd628adafdeb2a4b343e0d51d7168cdb186312
2019-06-14Fix RPC/pruneblockchain returned prune heightJonas Schnelli
Github-Pull: #15991 Rebased-From: 97f517dd851450b1ede1eb6b20f77691883a7737
2019-06-13gui: Enable open wallet menu on setWalletControllerJoão Barbosa
Github-Pull: #16118 Rebased-From: 75485ef0962a53946f17b761c4445627b07e6eff
2019-06-11Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet optionsLuke Dashjr
Github-Pull: #15913 Rebased-From: 765d5890be46ed5f5557c1d2b3cb931e6b8eb3b0
2019-06-11dummywallet: Reformat ignored wallet options listMarcoFalke
2019-06-07Add test for GCC bug 90348Pieter Wuille
Github-Pull: #15985 Rebased-From: 58e291cfad12fa85af87d093acfa7b44702e3521
2019-06-07gui: Set progressDialog to nullptrJoão Barbosa
Github-Pull: #16135 Rebased-From: d2ae6be80f6a0156021bf8c9b9d17cd4966ddffc
2019-06-07gui: Enable console line edit on setClientModelJoão Barbosa
Github-Pull: #16122 Rebased-From: 2d8ad2f99710a8981e33fe2d6ce834b0076c4e80
2019-06-07qt: fix opening bitcoin.conf via Preferences on macOS; see #15409shannon1916
Github-Pull: #16044 Rebased-From: 6e6494b3fb345848025494cb7a79c5bf8f35e417
2019-05-20Disallow extended encoding for non-witness transactions (take 3)MarcoFalke
Github-Pull: #16021 Rebased-From: fa2b52af32f6a4b9c22c270f36e92960c29ef364
2019-05-20Disallow extended encoding for non-witness transactionsPieter Wuille
Github-Pull: #14039 Rebased-From: bb530efa1872ec963417f61da9a95185c7a7a7d6
2019-05-18Show loaded wallets as disabled in open menu instead of nothingMeshCollider
Github-Pull: #15957 Rebased-From: c3ef63a52f304a600fff1f9c7caa5cb804d41d43
2019-05-17Doc: remove text about txes always relayed from -whitelistDavid A. Harding
Updates text since -whitelistforcerelay was set to false by default in PR #15193. Github-Pull: #15890 Rebased-From: e0bb2799992afe88e6f4efc6d90ed82ddf1ec5ec
2019-05-16doc: Mention blocksonly in reduce-traffic.md, unhide optionMarcoFalke
Github-Pull: #15990 Rebased-From: fa8ced32a60dea37ac169241cf9a1f708ef46c4b
2019-05-16net: Rename ::fRelayTxes to ::g_relay_txesMarcoFalke
This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d17bd0edf8a3a7cc81e55016f7fd8e7726 Github-Pull: #15990 Rebased-From: fa1dce7329d3e74d46ab98b93772b1832a3f1819
2019-04-18gui: Pre-rc4 translations updateWladimir J. van der Laan
Tree-SHA512: f3a7c9e0c935c869a85e3bc93a4bd33999270ffc13d35de34c46e9dab19229af19fb9c1a61a99264e8411c0966bf8b02a5ee94bf20a07f66b92234473f0e0801
2019-04-18Merge #15839: [0.18] Revert GetData randomization change (#14897)MarcoFalke
8602d8b213 Revert "Change in transaction pull scheduling to prevent InvBlock-related attacks" (Suhas Daftuar) Pull request description: This is for 0.18, not master -- I propose we revert the getdata change for the 0.18 release, rather than try to continue patching it up. It seems like we've turned up several additional bugs that slipped through initial review (see #15776, #15834), and given the potential severe consequences of these bugs I think it'd make more sense for us to delay releasing this code until 0.19. Since the bugfix PRs are getting review, I think we can leave #14897 in master, but we can separately discuss if it should be reverted in master as well if anyone thinks that would be more appropriate. ACKs for commit 8602d8: Tree-SHA512: 0389cefc1bc74ac47f87866cf3a4dcfe202740a1baa3db074137e0aa5859672d74a50a34ccdb7cf43b3a3c99ce91e4ba1fb512d04d1d383d4cc184a8ada5543f
2019-04-18GUI: Options: Remove the upper-bound limit from pruning size settingLuke Dashjr
Hypothetically, someone may wish to begin pruning at a future blockchain size, and there's no reason to limit it lower Github-Pull: #15801 Rebased-From: 8a33f4d63f9944f4877b3e2814b1582e72ceaa71 Tree-SHA512: 814dc5f004c3418216a12f8e0ef1a8db2c586d98b515d48b31a8ccd7f4e0deb12b9f2b6110bf702576a32802ca1d30e518df5ad7c28046deb4d0e9be46a6e7b8
2019-04-18GUI: Options: Set the range of pruning size before loading its valueLuke Dashjr
Without this, an out-of-default-range value gets limited to the range Github-Pull: #15801 Rebased-From: 4ddeb2f860eee98fbe94725ea8885368068a03f2 Tree-SHA512: 64c18c8be6756fc0130d3fe934edb1ea7758877d4049c5729fa2adb05abb3af4e4bbe1d5f910224e16070aada5470637a35ed14b12391efd48cf035e8a22a949
2019-04-17Revert "Change in transaction pull scheduling to prevent InvBlock-related ↵Suhas Daftuar
attacks" This reverts commit 1cff3d6cb017aea87d16cbda0768bbab256d16da.
2019-04-16Merge #15803: [0.18] Backport 15749: importmulti only imports origin info ↵MarcoFalke
for PKH outputs 235550d019 Take non-importing keys into account for spendability warning in descriptor import (Pieter Wuille) 802dcd37d1 Import all origin info in importmulti; even for non-importing pubkeys (Pieter Wuille) 7fcbe7dc11 Keep full pubkeys in FlatSigningProvider::origins (Pieter Wuille) Pull request description: Clean backport of #15749 by sipa to 0.18 ACKs for commit 235550: fanquake: utACK 235550d MarcoFalke: ACK 235550d019 (Checked that they are clean cherry-picks) Tree-SHA512: 1ccc19f51137ac4ef971c0bcca4c87ab2383610aa51c5d02680c485b9ce6abd698dddd7f4a45946d56b1aa741cc3fd94b4180ff15901824d20eeba89b4f12853
2019-04-16Take non-importing keys into account for spendability warning in descriptor ↵Pieter Wuille
import Github-Pull: #15749 Rebased-From: b5d39877242504160a7f2c24c60c07a845d7a064
2019-04-16Import all origin info in importmulti; even for non-importing pubkeysPieter Wuille
Github-Pull: #15749 Rebased-From: 6e597001a4fc1ba837f3f23cfd7f2d65c3d58104
2019-04-16Keep full pubkeys in FlatSigningProvider::originsPieter Wuille
Github-Pull: #15749 Rebased-From: 9a93c91c882265c908ea18496cd1bc271be914d4
2019-04-15Merge #15800: Backport: [rpc] Remove the addresses field from the ↵MarcoFalke
getaddressinfo return object b3a04c963d [rpc] Remove the addresses field from the getaddressinfo return object (John Newbery) Pull request description: Backport #15750 ACKs for commit b3a04c: MarcoFalke: ACK b3a04c963d4e761b66a1a8c1aae1c835534e47eb (checked cherry-pick) Tree-SHA512: d6e586fb6e22b9825267d6c45dd3090b7f8dc1a06804ca238103d1c665b178f8c2b3004f67aae67ea51c2c3df97561894f3f2e85d45400c760c3b7f057ff4bb8
2019-04-15[rpc] Remove the addresses field from the getaddressinfo return objectJohn Newbery
The "addresses" field was confusing because it refered to public keys using their P2PKH address. It was included in the return object when needed for backward compatibility. Remove that compatibility now that the -deprecatedrpc=validateaddress option has been removed. New applications should use the 'embedded'->'address' field for P2SH or P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig participants. Github-Pull: 15750 Rebased-From: b4338c151d4788c33f4b7c54daaf7f94b193a624
2019-04-11rpc: getrpcinfo docsBen Carman
Github-Pull: #15754 Rebased-From: f4b7a2f2055fa52d5e02c37bed7b46599b960e2e
2019-04-01wallet: Update transactions with current mempool after loadJoão Barbosa
Github-Pull: #15652 Rebased-From: 2ebf650b2eb7a078ab60c8c4d5c726823686f549
2019-04-01interfaces: Add Chain::requestMempoolTransactionsJoão Barbosa
Github-Pull: #15652 Rebased-From: 57908a739ca377d60ef224ce0f565d4412a414f4
2019-04-01wallet: Move CWallet::ReacceptWalletTransactions locks to callersJoão Barbosa
Github-Pull: #15652 Rebased-From: 0440481c6bf5683eff669c789bdf6a306d99adc5
2019-03-28Interrupt orphan processing after every transactionPieter Wuille
This makes orphan processing work like handling getdata messages: After every actual transaction validation attempt, interrupt processing to deal with messages arriving from other peers. Github-Pull: #15644 Rebased-From: 866c8058a706931f025335b3e794ed2f4d287918
2019-03-28[MOVEONLY] Move processing of orphan queue to ProcessOrphanTxPieter Wuille
Github-Pull: #15644 Rebased-From: 6e051f3d323af1d209c02e7a4319834f1947ffa7
2019-03-28Simplify orphan processing in preparation for interruptibilityPieter Wuille
Github-Pull: #15644 Rebased-From: 9453018fdc8f02d42832374bcf1d6e3a1df02281
2019-03-28qt: Translations update pre-rc3Wladimir J. van der Laan
Tree-SHA512: 52b66903e169fc3f53f8e4eccb0f765df9a6fbc149ba98fbe7f8b8e7f03e8196ebef8c19ed7412f6d09ddfa4b82e38aa357e1fca6942b0d1d7fe89ea66053556