| Age | Commit message (Collapse) | Author |
|---|
|
bitcoin-cli: remove unneeded dependencies (only minor code movement)
|
|
Remove unnecessary dependencies for bitcoin-cli
(leveldb, berkelydb, wallet, RPC server)
Build system changes:
- split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and
libbitcoin_cli.a
Code changes (movement only):
- split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli
in rpcclient.cpp
- move uiInterface from init.cpp to util.cpp
|
|
There were quite a few places where assert() was used with side effects,
making operation with NDEBUG non-functional. This commit fixes all the
cases I know about, but also adds an #error on NDEBUG because the code
is untested without assertions and may still have vulnerabilities if
used without assert.
|
|
less bytes, same images
|
|
bae6c7e Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. (Ryan Niebur)
|
|
was not necessary, as the field still receives focus without it.
|
|
|
|
mutex debugging routines: LocksHeld() and AssertLockHeld()
|
|
84b695c [Qt] allow deletion of payment-requests in sendcoins (Philip Kaufmann)
|
|
Also changes mempool to store CTxMemPoolEntries
to keep track of when they enter/exit the pool.
|
|
GetValueIn makes more sense as a CTransaction member.
|
|
This dead code can be resurrected from git history if
transaction replacement is ever implemented. Keeping
dead code in the source is a bad idea, because it implies
it was tested and worked at some point, which is not true.
|
|
9ac5a01 Move types.h include before ifaddres.h for u_int declaration (Robert Backhaus)
|
|
|
|
The SelectParamsFromCommandLine call was missing in bitcoin-cli,
which caused `-testnet` and `-regtest` to be ignored. Add this
call just like in bitcoind.cpp.
|
|
|
|
fb78cc2 Split up bitcoinrpc (code movement only) (Wladimir J. van der Laan)
|
|
a946aa8 Store and use a sanitized subVer (Mike Hearn)
ba6a4ea Add some additional logging to give extra network insight. (Mike Hearn)
|
|
Split bitcoinrpc up into
- rpcserver: bitcoind RPC server
- rpcclient: bitcoin-cli RPC client
- rpcprotocol: shared common HTTP/JSON-RPC protocol code
One step towards making bitcoin-cli independent from the rest
of the code, and thus a smaller executable that doesn't have to
be linked against leveldb.
This commit only does code movement, there are no functional changes.
|
|
This was removed by 25c0cce7f. It was apparently removed in qt5, but
may return for 5.1.
|
|
|
|
|
|
After discussing with BlueMatt, this appears to be harmless in its
current state since it's always set before it's used. Initialize it
anyway for readability and future safety.
|
|
c8b7425 setgenerate creates multiple blocks in -regtest mode (Gavin Andresen)
|
|
- this adds a delete button for insecure and secure payment requests in
the sendcoins dialog
- it also enables the delete button even for single and empty entries, as
this is much easier to handle and doesn't need to special case single
entries
- big parts of the ui file were changed, because I copied the delete
button and had to delete the layout too and created it from scratch
(which seems to cleanup the rows and colums in the layout also, which is
nice IMHO)
|
|
848fe68 cleanup error message consistency (Julian Langschaedel)
|
|
|
|
fb0507f qt: show all units in send confirmation (Wladimir J. van der Laan)
|
|
relicts from the CTransaction refactor.
|
|
I'm writing some wallet regression tests using -regtest mode, and
need to generate an initial multi-hundred-block chain. Repeatedly
calling setgenerate to generate one block is slow and doesn't
work properly, because block creation happens asynchronously.
This adds two features to setgenerate in -regtest mode:
1) Instead of being interpreted as number of threads to start, the
third argument is the number of blocks to generate.
2) setgenerate will not return until the block creation threads
have created the requested number of blocks.
|
|
67448b2 [Qt] make a UI element in sendcoins non-validated (Philip Kaufmann)
|
|
RPC client option: -rpcwait, to wait for server start
|
|
379778b core: remove includes in .cpp, if header is already in .h (Philip Kaufmann)
|
|
- this was unused for the label and also makes no sense, so remove it
|
|
|
|
- Add support for Clang
Further details can be found at http://savannah.gnu.org/patch/?8186
|
|
- Use 'ls -r' in order to try newer version before older ones. Simplify
ls pattern so also dylibs are detected.
|
|
- Use 'ls -r' rather than non-portable tool 'tac'. Simplify filepattern in ls expression so dylib (on OSX) are also detected.
|
|
- Fixed detection of dynamic libraries on Mac OS X (*.dylib)
See http://savannah.gnu.org/patch/?7719 for further details.
|
|
- Fixed cut-and-paste error.
- See http://savannah.gnu.org/patch/?7576 for further details.
- Use 'ls -r' rather than non-portable tool 'tac'.
- Simplify filepattern in ls expression so dylib (on OSX) are also detected.
|
|
- Add aarch64 to the list of lib64 architectures
|
|
0689f46 Coincontrol cleanup (e.g. add missing license) (Philip Kaufmann)
|
|
- add missing license headers
- make compatible with Qt5
- enforce header cleanup style
- small code style cleanups
- rename Coin Control dialog into Coin Control Address Selection
- use default font for the windows labels (no monospace)
|
|
Make users accustomed to the other subdivision units (mBTC, muBTC)
by showing the total amount in all units in the confirmation dialog.
This was recently raised on the mailing list and could be a preparation
for switching over the default unit eventually.
|
|
I was merging change this every time before generation of
the doxygen developer docs (https://dev.visucore.com/bitcoin/doxygen/)
but there's no reason why it can't just be merged upstream.
|
|
|
|
6a86c24 Coin Control Features (Cozz Lovan)
8dfd8c6 pass nBytes as parameter to GetMinFee(..) (Cozz Lovan)
|
|
309f796 [Qt] make most Windows appear centered on main GUI (Philip Kaufmann)
|
|
|
|
- example: if util.h includes stdint.h, remove it from util.cpp, as
util.h is the first header included in util.cpp
|
