| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Otherwise, if CCoinsViewCache::ModifyCoins throws an exception in between
setting hasModifier and constructing the CCoinsModifier, the cache ends up
in an inconsistent state, resulting in an assert failure in the next
modification.
Bug discovered by Wladimir J. van der Laan.
|
|
469d564 Build winshutdownmonitor.cpp on Windows only. (Pavel Janík)
|
|
be43492 build: fix 'make distcheck' (Cory Fields)
|
|
7c5dd60 Adding RPC tests for the following wallet related calls: getbalance, listsinceblock, listtransactions, listlockunspent, listaccounts listaddressgroupings (Everett Forth)
|
|
The text talked about "Quit" while Bitcoin uses "Exit" in its menu.
|
|
|
|
|
|
13f9031 init: minor parameter interaction updates (Philip Kaufmann)
|
|
a15dba5 en: Avoid ambiguous language regarding when transactions confirm (Luke Dashjr)
|
|
Previously an empty script wouldn't be hashed, and CScriptID would be
assigned the incorrect value of 0 instead. This bug can be seen in the
RPC decodescript command:
$ btc decodescript ""
{
"asm" : "",
"type" : "nonstandard",
"p2sh" : "31h1vYVSYuKP6AhS86fbRdMw9XHieotbST"
}
Correct output:
$ btc decodescript ""
{
"asm" : "",
"type" : "nonstandard",
"p2sh" : "3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy"
}
|
|
|
|
c907704 DOS: Respect max per-peer blocks in flight limit (Adam Weiss)
|
|
6484930 Apply AreSane() checks to the fees from the network. (Gregory Maxwell)
|
|
aa279d6 Enforce minRelayTxFee on wallet created tx and add a maxtxfee option. (Gregory Maxwell)
|
|
3497022 Reject headers that build on an invalid parent (Pieter Wuille)
|
|
listsinceblock, listtransactions, listlockunspent, listaccounts
listaddressgroupings
|
|
Don't allow immediate inv driven block downloads if
a peer already has MAX_BLOCKS_IN_TRANSIT_PER_PEER
active downloads. Prevents bogus inv spam from
blowing up block transfer tracking data structures.
|
|
|
|
4bc95c4 remove max orphan blocks config parameter since it is no longer functional (Jameson Lopp)
|
|
7c041b3 Check against MANDATORY flags prior to accepting to mempool (Peter Todd)
|
|
|
|
Rather than treating the .py as a regular built test, run it from check-local
so that we can better control the paths used.
|
|
Previously the minRelayTxFee was only enforced on user specified values.
It was possible for smartfee to produce a fee below minRelayTxFee which
would just result in the transaction getting stuck because it can't be
relayed.
This also introduces a maxtxfee option which sets an absolute maximum
for any fee created by the wallet, with an intention of increasing
user confidence that the automatic fees won't burn them. This was
frequently a concern even before smartfees.
If the configured fee policy won't even allow the wallet to meet the relay
fee the transaction creation may be aborted.
|
|
Github-Pull: #5494
Rebased-From: 15de949bb9277e442302bdd8dee299a8d6deee60
|
|
78253fc Remove references to X11 licence (Michael Ford)
|
|
ba7fcc8 Discourage fee sniping with nLockTime (Peter Todd)
|
|
Rebased-From: ccd056a30db0ba5e04b858a682907b378e464d34
Github-Pull: #5437
|
|
4709160 [Qt] fix a translation that occurs 2 times but was a little different (Philip Kaufmann)
50db7d9 [Qt] change some strings to reflect name change to Bitcoin Core (Philip Kaufmann)
2747f7c [Qt] fix missing plural form for a string in sendcoinsdialog (Philip Kaufmann)
|
|
cac15be Test unexecuted OP_CODESEPARATOR (Peter Todd)
|
|
The comment has been around since 0.1, but NTP inside the client
isn't deemed necessary so remove the comment to avoid confusion.
|
|
|
|
7c8e4c5 Make pass-by-ref arguments const. (Daniel Kraft)
|
|
- I saw this on http://en.cppreference.com/w/cpp/language/try_catch and
thought it would be a good idea
- also unify used format to better be able to search for exception
uses in our codebase
|
|
Make some of the arguments in rest.cpp, that are passed by
reference but never modified, const to emphasise that.
|
|
Changing the icons color for regtest in now lightweight.
|
|
|
|
4a8fc15 [Qt] the RPC Console should be a QWidget to make window more independent (Jonas Schnelli)
|
|
Rebased-From: 67b2d819cdf6181e7f016e5366ce7479830893bd
Github-Pull: #5404
|
|
|
|
|
|
- remove splash screen images (reduce binary size)
- dynamicly draw splash screen with available icon.
- remove testnet icon
- dynamicly colorize testnet icon
|
|
31aac02 Qt: new icons (Jonas Schnelli)
|
|
f676c80 Add /rest/headers (Pieter Wuille)
|
|
|
|
|
|
'Sane' was already defined by this code as:
fee.GetFeePerK() > minRelayFee.GetFeePerK() * 10000
But sanity was only enforced for data loaded from disk.
Note that this is a pretty expansive definition of 'sane': A 10 BTC
fee is still passes the test if its on a 100kb transaction.
This prevents a single insane fee on the network from making us reject
our stored fee data at start. We still may reject valid saved fee
state if minRelayFee is changed between executions.
This also reduces the risk and limits the damage from a cascading
failure where one party pays a bunch of insane fees which cases
others to pay insane fees.
|
|
5ea3bc0 Move remaining CBlockIndex methods to chain.cpp (Pieter Wuille)
9dcd524 Make IsSuperMajority a standalone function (Pieter Wuille)
|
|
|
|
aa768f1 signrawtransaction: validate private key. (Pavel Janík)
|
